8000 imp(ante): Remove automatic withdrawal of staking rewards in case of insufficient funds (backport #2719) by mergify[bot] · Pull Request #2801 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

imp(ante): Remove automatic withdrawal of staking rewards in case of insufficient funds (backport #2719) #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

8000 Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2024
Merged

imp(ante): Remove automatic withdrawal of staking rewards in case of insufficient funds (backport #2719) #2801

merged 2 commits into from
Sep 2, 2024

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Aug 30, 2024

This PR removes the logic associated with the automatic withdrawal of staking rewards in case a user has not enough funds to pay for the transaction fees.
This feature is not going to work with ICS and has also been a point of critique for the taxable event that is created and subsequently removed from different partner's forks.

Summary by CodeRabbit

  • New Features

    • Simplified fee deduction process with improved error handling.
    • Enhanced clarity in error messages related to fee deduction failures.

  • Bug Fixes

    • Clarified test cases for better focus on insufficient funds scenarios.
    • Improved consistency in expected error messages across tests.

  • Refactor

    • Removed unnecessary helper functions to streamline logic.
    • Shifted from structured error types to descriptive string messages in tests.

  • Documentation

    • Updated CHANGELOG to reflect significant changes in staking reward management.
This is an automatic backport of pull request #2719 done by [Mergify](https://mergify.com).

@MalteHerrmann @mergify
imp(ante): Remove automatic withdrawal of staking rewards in case of …
e09bde7 
…insufficient funds (#2719)

* remove automatic withdrawal of staking rewards in case of insufficient funds

* add changelog entry

(cherry picked from commit b591299)

# Conflicts:
#	CHANGELOG.md
@mergify Mergify
Copy link
Contributor Author
mergify bot commented Aug 30, 2024

Cherry-pick of b591299 has failed:

On branch mergify/bp/Vvaradinov/ics-devnet/pr-2719
Your branch is up to date with 'origin/Vvaradinov/ics-devnet'.

You are currently cherry-picking commit b591299b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   app/ante/cosmos/fees.go
	modified:   app/ante/cosmos/fees_test.go
	modified:   app/ante/evm/09_gas_consume.go
	modified:   app/ante/evm/09_gas_consume_test.go
	deleted:    app/ante/integration_test.go
	deleted:    app/ante/utils/claim_rewards.go
	deleted:    app/ante/utils/claim_rewards_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team as a code owner August 30, 2024 15:45
@mergify mergify bot added the conflicts label Aug 30, 2024
@mergify mergify bot requested review from hanchon and GAtom22 and removed request for a team August 30, 2024 15:45
@mergify mergify bot mentioned this pull request Aug 30, 2024
Merged
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Aug 30, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the tests label Aug 30, 2024
@Vvaradinov Vvaradinov merged commit 53251f0 into Vvaradinov/ics-devnet Sep 2, 2024
18 of 23 checks passed
@Vvaradinov Vvaradinov deleted the mergify/bp/Vvaradinov/ics-devnet/pr-2719 branch September 2, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@GAtom22 GAtom22 GAtom22 approved these changes

@hanchon hanchon Awaiting requested review from hanchon hanchon is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
conflicts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fedekunze @GAtom22 @Vvaradinov @MalteHerrmann
0