feat(app): add feemarket wrapper. Change basefee to dec #2878
Conversation
|
Warning Rate limit exceeded@ramacarlucho has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 7 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes across multiple files enhance the Evmos project, focusing on updates in account management, transaction handling, and fee management. Key modifications include the removal of the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: stepit <48993133+0xstepit@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
x/evm/types/scaling.go (2)
28-34: LGTM: Function logic is correct. Consider improving documentation.The logic of
ConvertAmountTo18DecimalsLegacyis correct and aligns with the file's purpose. However, to improve maintainability and clarity:
- Add a more detailed comment explaining why this function uses
LegacyDecand how it differs from other conversion functions.- Consider adding an example usage in the function's documentation.
Here's a suggested improvement for the function documentation:
// ConvertAmountTo18DecimalsLegacy converts the given amount from its original // decimal representation to 18 decimals using LegacyDec for backwards compatibility. // This function is used in legacy parts of the system that still rely on LegacyDec. // // Example usage: // // originalAmount := sdkmath.LegacyNewDec(1000000) // Assuming 6 decimals // convertedAmount := ConvertAmountTo18DecimalsLegacy 8000 (originalAmount) // // convertedAmount will be 1000000000000000000 (18 decimals) func ConvertAmountTo18DecimalsLegacy(amt sdkmath.LegacyDec) sdkmath.LegacyDec { // ... (existing function body) }🧰 Tools
🪛 GitHub Check: test-unit-cover
[failure] 31-31:
undefined: evmtypes
[failure] 31-31:
undefined: evmtypes🪛 GitHub Check: Run golangci-lint
[failure] 31-31:
undefined: evmtypes) (typecheck)
[failure] 31-31:
undefined: evmtypes) (typecheck)
[failure] 31-31:
undefined: evmtypes) (typecheck)🪛 GitHub Check: ante-benchmark-test
[failure] 31-31:
undefined: evmtypes🪛 GitHub Check: test-solidity
[failure] 31-31:
undefined: evmtypes🪛 GitHub Check: dependency-review
[failure] 31-31:
undefined: evmtypes🪛 GitHub Check: build
[failure] 31-31:
undefined: evmtypes
28-34: Document the rationale and future plans for legacy decimal handling.The addition of
ConvertAmountTo18DecimalsLegacyusingsdkmath.LegacyDecsuggests a transition period or backwards compatibility requirement. To improve long-term maintainability and clarity:
- Add a comment at the package level or in a central documentation file explaining the rationale for introducing this legacy function.
- Document any plans for future updates to decimal handling in the system.
- If applicable, create a tracking issue for eventually migrating away from
LegacyDecusage.Would you like assistance in drafting this documentation or creating a tracking issue?
🧰 Tools
🪛 GitHub Check: test-unit-cover
[failure] 31-31:
undefined: evmtypes
[failure] 31-31:
undefined: evmtypes🪛 GitHub Check: Run golangci-lint
[failure] 31-31:
undefined: evmtypes) (typecheck)
[failure] 31-31:
undefined: evmtypes) (typecheck)
[failure] 31-31:
undefined: evmtypes) (typecheck)🪛 GitHub Check: ante-benchmark-test
[failure] 31-31:
undefined: evmtypes🪛 GitHub Check: test-solidity
[failure] 31-31:
undefined: evmtypes🪛 GitHub Check: dependency-review
[failure] 31-31:
undefined: evmtypes🪛 GitHub Check: build
[failure] 31-31:
undefined: evmtypes
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- x/evm/types/scaling.go (2 hunks)
🧰 Additional context used
🪛 GitHub Check: test-unit-cover
x/evm/types/scaling.go
[failure] 31-31:
undefined: evmtypes
[failure] 31-31:
undefined: evmtypes
🪛 GitHub Check: Run golangci-lint
x/evm/types/scaling.go
[failure] 31-31:
undefined: evmtypes) (typecheck)
[failure] 31-31:
undefined: evmtypes) (typecheck)
[failure] 31-31:
undefined: evmtypes) (typecheck)
🪛 GitHub Check: ante-benchmark-test
x/evm/types/scaling.go
[failure] 31-31:
undefined: evmtypes
🪛 GitHub Check: test-solidity
x/evm/types/scaling.go
[failure] 31-31:
undefined: evmtypes
🪛 GitHub Check: dependency-review
x/evm/types/scaling.go
[failure] 31-31:
undefined: evmtypes
🪛 GitHub Check: build
x/evm/types/scaling.go
[failure] 31-31:
undefined: evmtypes
🔇 Additional comments (1)
x/evm/types/scaling.go (1)
10-10: LGTM: Import addition is correct and necessary.The addition of
sdkmath "cosmossdk.io/math"is appropriate for the new function's use ofsdkmath.LegacyDec.
Description
Add changes from #2777
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.mdSummary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests
Chores