8000 chore: fix wrong error message (backport #2581) by mergify[bot] · Pull Request #2591 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fix wrong error message (backport #2581) #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

chore: fix wrong error message (backport #2581) #2591

merged 1 commit into from
May 31, 2024

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented May 31, 2024

Description

Fix an error message returned in case of missing chainID for dynamic fee tx.

This PR should be backported in the V18.1.0 release too.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed
This is an automatic backport of pull request #2581 done by [Mergify](https://mergify.com).

@0xstepit @mergify
chore: fix wrong error message (#2581)
ccb637a 
* fix wrong error message

* add changelog entry

(cherry picked from commit 7db8cca)
@mergify mergify bot requested a review from a team as a code owner May 31, 2024 13:05
@mergify mergify bot requested review from ramacarlucho and facs95 May 31, 2024 13:05
@mergify mergify bot mentioned this pull request May 31, 2024
Merged
9 tasks
@0xstepit 0xstepit enabled auto-merge (squash) May 31, 2024 13:06
@0xstepit 0xstepit merged commit 320dc86 into release/v18.x.x May 31, 2024
36 of 38 checks passed
@0xstepit 0xstepit deleted the mergify/bp/release/v18.x.x/pr-2581 branch May 31, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@0xstepit 0xstepit 0xstepit approved these changes

@ramacarlucho ramacarlucho Awaiting requested review from ramacarlucho ramacarlucho is a code owner automatically assigned from evmos/core-engineering

@facs95 facs95 Awaiting requested review from facs95 facs95 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vvaradinov @0xstepit
0