fix(evm): duplicate event emitting #2559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramacarlucho
approved these changes
May 17, 2024
facs95
pushed a commit
that referenced
this pull request
May 29, 2024
* fix: duplicate event emitting * CHANGELOG * CHANGELOG
GAtom22
pushed a commit
that referenced
this pull request
May 29, 2024
peara
pushed a commit
to aura-nw/evmos
that referenced
this pull request
Jun 25, 2024
MaxMustermann2
added a commit
to MaxMustermann2/exocore
that referenced
this pull request
Sep 23, 2024
MaxMustermann2
added a commit
to imua-xyz/imuachain
that referenced
this pull request
Oct 13, 2024
* fix: EBT-03 * fix: ENG-04 * fix: ENG-06 * fix: ENO-02 * fix: ENO-03 * fix: IGE-01 * fix: NBT-01 * fix: URW-01 * chore: lint * fix: TRO-01 * fix: RTE-01 * fix: NKR-01 evmos/evmos#2559 * fix: EIO-02 * fix: EIO-01 * fix: ENG-03 An AVS can be registered by non-operators as well * fix(oracle): don't use Mode as int32 * fix: more validation of lengths in sigverify * refactor(delegation): respond to ai comments Instead of ignoring the error (even though we know it to be nil), examine the error and skip the loop if it is not nil. This is preferred over changing the function interface since it is more future proof. * fix(ci): upgrade Docker curl version * fix: error duplicate asset registration * fix: optimize store open + add TODO * refactor: respond to AI comments * doc: remove superfluous comment * doc: add comment on evm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the duplicate event emitting of cached events which causes Delegate transactions (possibly others as well) through precompiles to double the events emitted.
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md