8000 Undo the replaces, while bumping versions by faddat · Pull Request #170 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Undo the replaces, while bumping versions #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 13, 2021
Merged

Undo the replaces, while bumping versions #170

merged 6 commits into from
Dec 13, 2021

Conversation

faddat
Copy link
Contributor
@faddat faddat commented Dec 12, 2021 •
edited
Loading

Description

Turns out that go.sum has literally nothing to do with the code that the compiler uses, and the previous commit wasn't necessary at all.

to know what the compiler will actually use, it's more like:

go list -m all

#165

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze
fedekunze reviewed Dec 12, 2021
View reviewed changes
@faddat
Copy link
Contributor Author
faddat commented Dec 13, 2021 •
edited
Loading

PS:

the tl;dr on this is kinda... ymmv-- look what cro came up with on their own:

https://github.com/crypto-org-chain/chain-main/blob/master/go.mod

So, that somewhat indicates that my original thinking might have been right. But if we're to believe go list -m all then should be okay. I am a bit puzzled by all of this and I'll keep watching how it plays out over the next month or two.

@fedekunze fedekunze merged commit d16ca65 into evmos:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faddat @fedekunze
0