evmos · facs95 · Jun 16, 2023 · Apr 24, 2023 · Apr 25, 2023 · Apr 27, 2023
@@ -25,7 +25,7 @@ jobs:
             **/**.go
             go.mod
             go.sum
-      - uses: golangci/golangci-lint-action@v3.5.0
+      - uses: golangci/golangci-lint-action@v3.6.0
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
           version: latest

@@ -37,11 +37,16 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 # Changelog
 
-## [v13.0.0-rc2] - 2023-06-13 
+## [v13.0.0-rc3] - 2023-06-15
+
+### Bug Fixes
+
+- (evm) [160](https://github.com/evmos/precompiles/pull/160) Fixed hard coded BaseDenom and wrong comparison for MaxUint256
+
+## [v13.0.0-rc2] - 2023-06-13
 
 ### State Machine Breaking
 
-- (backport) [#1599](https://github.com/evmos/evmos/pull/1599) Backport changes from `main` to `v13.0.x`
 - (vesting) [#1596](https://github.com/evmos/evmos/pull/1596) Add MsgCreateClawbackVestingAccount period validation
 - (evm) [#1535](https://github.com/evmos/evmos/pull/1535) Add EVM extensions support
 

@@ -151,7 +151,6 @@ code under an open source license.
 **A:** No, unless you have obtained a commercial permit for the ENCL code or can
 ensure compliance with the limitations in ENCL-1.0.
 
-
 **Q: If I modify the source code of software licensed under the ENCL-1.0,
 can I redistribute my modified version under an Open Source license, e.g. MIT or Apache 2.0?**
 

@@ -16,7 +16,7 @@ require (
 	github.com/davecgh/go-spew v1.1.1
 	github.com/ethereum/go-ethereum v1.11.5
 	github.com/evmos/evmos-ledger-go v0.4.0
-	github.com/evmos/precompiles v0.0.0-20230612174323-5d708df47c51
+	github.com/evmos/precompiles v0.0.0-20230615165716-e0a8cabcbf5d
 	github.com/gogo/protobuf v1.3.3
 	github.com/golang/protobuf v1.5.3
 	github.com/gorilla/mux v1.8.0

@@ -490,8 +490,8 @@ github.com/evmos/evmos-ledger-go v0.4.0 h1:WPa6TN9x7s/+1YCgvYGtzJrhlW/mIHtYM1DvN
 github.com/evmos/evmos-ledger-go v0.4.0/go.mod h1:33X3wWcWZ68KD5Bj4aiED+/W57uO1VR+hbXBxkKDXsQ=
 github.com/evmos/go-ethereum v1.10.26-evmos-rc2 h1:tYghk1ZZ8X4/OQ4YI9hvtm8aSN8OSqO0g9vo/sCMdBo=
 github.com/evmos/go-ethereum v1.10.26-evmos-rc2/go.mod h1:/6CsT5Ceen2WPLI/oCA3xMcZ5sWMF/D46SjM/ayY0Oo=
-github.com/evmos/precompiles v0.0.0-20230612174323-5d708df47c51 h1:TNGz8Rd03gjN2Yp1/BLVTjbf6nzs/h835cKi57RGmPI=
-github.com/evmos/precompiles v0.0.0-20230612174323-5d708df47c51/go.mod h1:MZslgxAhNqL+g9TOhv+et+F3n61akuMb/wBzQe7eMIE=
+github.com/evmos/precompiles v0.0.0-20230615165716-e0a8cabcbf5d h1:Amope5DymYdDs/DU2I6zMX/fZ+xb+U87PQZ4lLtL55k=
+github.com/evmos/precompiles v0.0.0-20230615165716-e0a8cabcbf5d/go.mod h1:EN85gINi4B+pjzbdPgqNNw9O1Oras++7gJEZAXD1K4E=
 github.com/facebookgo/ensure v0.0.0-20200202191622-63f1cf65ac4c h1:8ISkoahWXwZR41ois5lSJBSVw4D0OV19Ht/JSTzvSv0=
 github.com/facebookgo/stack v0.0.0-20160209184415-751773369052 h1:JWuenKqqX8nojtoVVWjGfOF9635RETekkoH6Cc9SX0A=
 github.com/facebookgo/subset v0.0.0-20200203212716-c811ad88dec4 h1:7HZCaLC5+BZpmbhCOZJ293Lz68O7PYrF2EzeiFMwCLk=

@@ -26,8 +26,9 @@ type MockIBCModule struct {
 // OnChanOpenInit implements the Module interface
 // It calls the underlying app's OnChanOpenInit callback.
 //
+//	and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
+//
 //nolint:all // escaping govet since we can copy locks here as it is a test
-//              and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
 func (m MockIBCModule) OnChanOpenInit(
 	ctx sdk.Context,
 	order channeltypes.Order,
@@ -45,8 +46,9 @@ func (m MockIBCModule) OnChanOpenInit(
 // OnChanOpenTry implements the Module interface.
 // It calls the underlying app's OnChanOpenTry callback.
 //
+//	and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
+//
 //nolint:all // escaping govet since we can copy locks here as it is a test
-//              and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
 func (m MockIBCModule) OnChanOpenTry(
 	ctx sdk.Context,
 	order channeltypes.Order,
@@ -64,8 +66,9 @@ func (m MockIBCModule) OnChanOpenTry(
 // OnChanOpenAck implements the Module interface.
 // It calls the underlying app's OnChanOpenAck callback.
 //
+//	and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
+//
 //nolint:all // escaping govet since we can copy locks here as it is a test
-//              and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
 func (m MockIBCModule) OnChanOpenAck(
 	ctx sdk.Context,
 	portID,
@@ -80,8 +83,9 @@ func (m MockIBCModule) OnChanOpenAck(
 // OnChanOpenConfirm implements the Module interface.
 // It calls the underlying app's OnChanOpenConfirm callback.
 //
+//	and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
+//
 //nolint:all // escaping govet since we can copy locks here as it is a test
-//              and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
 func (m MockIBCModule) OnChanOpenConfirm(
 	ctx sdk.Context,
 	portID,
@@ -94,8 +98,9 @@ func (m MockIBCModule) OnChanOpenConfirm(
 // OnChanCloseInit implements the Module interface
 // It calls the underlying app's OnChanCloseInit callback.
 //
+//	and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
+//
 //nolint:all // escaping govet since we can copy locks here as it is a test
-//              and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
 func (m MockIBCModule) OnChanCloseInit(
 	ctx sdk.Context,
 	portID,
@@ -108,8 +113,9 @@ func (m MockIBCModule) OnChanCloseInit(
 // OnChanCloseConfirm implements the Module interface.
 // It calls the underlying app's OnChanCloseConfirm callback.
 //
+//	and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
+//
 //nolint:all // escaping govet since we can copy locks here as it is a test
-//              and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
 func (m MockIBCModule) OnChanCloseConfirm(
 	ctx sdk.Context,
 	portID,
@@ -122,8 +128,9 @@ func (m MockIBCModule) OnChanCloseConfirm(
 // OnRecvPacket implements the Module interface.
 // It calls the underlying app's OnRecvPacket callback.
 //
+//	and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
+//
 //nolint:all // escaping govet since we can copy locks here as it is a test
-//              and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
 func (m MockIBCModule) OnRecvPacket(
 	ctx sdk.Context,
 	packet channeltypes.Packet,
@@ -136,8 +143,9 @@ func (m MockIBCModule) OnRecvPacket(
 // OnAcknowledgementPacket implements the Module interface.
 // It calls the underlying app's OnAcknowledgementPacket callback.
 //
+//	and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
+//
 //nolint:all // escaping govet since we can copy locks here as it is a test
-//              and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
 func (m MockIBCModule) OnAcknowledgementPacket(
 	ctx sdk.Context,
 	packet channeltypes.Packet,
@@ -151,8 +159,9 @@ func (m MockIBCModule) OnAcknowledgementPacket(
 // OnTimeoutPacket implements the Module interface.
 // It calls the underlying app's OnTimeoutPacket callback.
 //
+//	and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
+//
 //nolint:all // escaping govet since we can copy locks here as it is a test
-//              and escaping revive for unused parameters which are okay since they indicate the expected mocked interface
 func (m MockIBCModule) OnTimeoutPacket(
 	ctx sdk.Context,
 	packet channeltypes.Packet,

@@ -864,7 +864,7 @@ var _ = Describe("Clawback Vesting Accounts - claw back tokens", Ordered, func()
 	})
 })
 
-// Trying to replicate the faulty behaviour in MsgCreateClawbackVestingAccount,
+// Trying to replicate the faulty behavior in MsgCreateClawbackVestingAccount,
 // that was disclosed as a potential attack vector in relation to the Barberry
 // security patch.
 //
@@ -904,7 +904,7 @@ var _ = Describe("Clawback Vesting Account - Barberry bug", func() {
 	})
 
 	Context("when creating a clawback vesting account", func() {
-		var testcases = []struct {
+		testcases := []struct {
 			name         string
 			lockupCoins  sdk.Coins
 			vestingCoins sdk.Coins

@@ -86,7 +86,7 @@ func (msg MsgCreateClawbackVestingAccount) ValidateBasic() error {
 		vestingCoins = vestingCoins.Add(period.Amount...)
 	}
 
-    // If neither schedule is present, the message is invalid.
+	// If neither schedule is present, the message is invalid.
 	if len(lockupCoins) == 0 && len(vestingCoins) == 0 {
 		return errorsmod.Wrapf(errortypes.ErrInvalidRequest, "vesting and/or lockup schedules must be present")
 	}