8000 chore (app, deps): address open points for rc4 release by MalteHerrmann · Pull Request #1190 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore (app, deps): address open points for rc4 release #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 23, 2022
Merged

chore (app, deps): address open points for rc4 release #1190

merged 7 commits into from
Dec 23, 2022

Conversation

MalteHerrmann
Copy link
Contributor
@MalteHerrmann MalteHerrmann commented Dec 23, 2022 •
edited
Loading

This PR does the following:

  • revert default mempool configuration back to v0 (FIFO mempool) as we have seen this being detrimental to node performance
  • update our fork of the Cosmos SDK to v0.46.7
  • add some missing changelog entries, that were only on the release branch as of yet

Closes ENG-1255

VictorTrustyDev
VictorTrustyDev reviewed Dec 23, 2022
View reviewed changes
@linear
Copy link
linear bot commented Dec 23, 2022
ENG-1255 Revert mempool default to v0

Create a new PR to revert the following change on cmd/evmosd/root.go

cfg.Mempool.Version = tmcfg.MempoolV1

The PR then will need to be backported to the v10 release branch

fedekunze
fedekunze reviewed Dec 23, 2022
View reviewed changes
fedekunze
fedekunze reviewed Dec 23, 2022
View reviewed changes
@VictorTrustyDev VictorTrustyDev mentioned this pull request Dec 23, 2022
Closed
4 tasks
@MalteHerrmann MalteHerrmann marked this pull request as ready for review December 23, 2022 09:16
@MalteHerrmann MalteHerrmann requested a review from a team as a code owner December 23, 2022 09:16
@MalteHerrmann MalteHerrmann requested review from Vvaradinov and 4rgon4ut and removed request for a team December 23, 2022 09:17
@fedekunze fedekunze merged commit 6e83c7e into main Dec 23, 2022
@fedekunze fedekunze deleted the malte/address-rc4-open-points branch December 23, 2022 10:14
@MalteHerrmann
Copy link
Contributor Author

https://github.com/Mergifyio backport release/v10.0.x

mergify bot pushed a commit that referenced this pull request Dec 23, 2022
@MalteHerrmann @mergify
chore (app, deps): address open points for rc4 release (#1190)
9a7a86f 
* revert default mempool back to 0

* prepare v10/constants.go for v10.0.0-rc4

* remove Cosmos SDK replace in go.mod

* update changelog entries

* Update cmd/evmosd/root.go

* use v0.46.7 on cosmos sdk fork

* Revert "prepare v10/constants.go for v10.0.0-rc4"

This reverts commit 2d8b761.

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 6e83c7e)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Dec 23, 2022
Merged
@mergify
Copy link
Contributor
mergify bot commented Dec 23, 2022

backport release/v10.0.x

✅ Backports have been created

danburck pushed a commit that referenced this pull request Dec 23, 2022
@mergify @MalteHerrmann
chore (app, deps): address open points for rc4 release (backport #1190)…
8a89a38 
… (#1192)

* chore (app, deps): address open points for rc4 release (#1190)

* revert default mempool back to 0

* prepare v10/constants.go for v10.0.0-rc4

* remove Cosmos SDK replace in go.mod

* update changelog entries

* Update cmd/evmosd/root.go

* use v0.46.7 on cosmos sdk fork

* Revert "prepare v10/constants.go for v10.0.0-rc4"

This reverts commit 2d8b761.

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 6e83c7e)

# Conflicts:
#	CHANGELOG.md

* fix conflicts in changelog

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: MalteHerrmann <malte@evmos.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorTrustyDev VictorTrustyDev VictorTrustyDev left review comments

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@fedekunze fedekunze fedekunze approved these changes

@4rgon4ut 4rgon4ut Awaiting requested review from 4rgon4ut 4rgon4ut is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MalteHerrmann @Vvaradinov @fedekunze @VictorTrustyDev
0