chore(release): v10-rc2 #1142
Merged
chore(release): v10-rc2 #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing --home flags to evmosd config commands * Change temporary folder name to the common .tmp-... * Rename init.sh to local_node.sh for clarity * Apply renaming of init.sh also to the docs
* Set validator's min commission * Remove min-commission ante * Update CHANGELOG * delete decorator * changelog * c++ * update init * upgrade logic Co-authored-by: Giancarlos Salas <me@giansalex.dev>
Bumps [go.opencensus.io](https://github.com/census-instrumentation/opencensus-go) from 0.23.0 to 0.24.0. - [Release notes](https://github.com/census-instrumentation/opencensus-go/releases) - [Commits](census-instrumentation/opencensus-go@v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: go.opencensus.io dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <facs95@gmail.com>
This reverts commit 36e7dd6.
Added Pocket Network public endpoint Co-authored-by: Freddy Caceres <facs95@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
* imp(erc20): util functions * c++
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.4.0...v2.5.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updated POKT entry to include close square-bracket for their link and moved them to the bottom of the list to be fair to others (historically others have added to the bottom rather than to the top)
…1063) Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
…nks + update out-dated links (#1071) * update evmos binary version * update evmos testnet upgrade * rename github.com/tharis/evmos into github.com/evmos/evmos * update markdown link tendermint from removed style branch master into current evmos tendermint v0.34 * fixed dead link #restart-node into full url + #_4-restart-node
) Bumps [github.com/cosmos/ibc-go/v5](https://github.com/cosmos/ibc-go) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v5.1.0/CHANGELOG.md) - [Commits](cosmos/ibc-go@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…34.23 (#1067) build(deps): bump github.com/tendermint/tendermint Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.34.22 to 0.34.23. - [Release notes](https://github.com/tendermint/tendermint/releases) - [Changelog](https://github.com/tendermint/tendermint/blob/v0.34.23/CHANGELOG.md) - [Commits](tendermint/tendermint@v0.34.22...v0.34.23) --- updated-dependencies: - dependency-name: github.com/tendermint/tendermint dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: amino enconding support for the vesting module * fix: missing enconding added * chore: update changelog * chore: remove temp files
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.24.0 to 1.24.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.24.0...v1.24.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
…1079) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.0 to 3.3.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3.3.0...v3.3.1) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
refactor (errors) refactor errors import to use cosmossdk.io instead of cosmos-sdk/types/errors
* ibc utils for erc20 middleware * use defined constant * apply from review * Apply suggestions from code review Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * fix test name * add changelog entry Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
fix use of home directory in local node script
* Add initial version of audits page * Add changelog entry * Fix linebreaks
…ackVestingAccount (#1087) * feature (vesting) add functionality to update vesting funder in ClawbackVestingAccount * feature (vesting) add changes in changelog file * feature (vesting) add documentation for UpdateVestingFunder * feature (vesting) add integration tests * feature (vesting) fix linting errors * feature (vesting) fix style errors * Update x/vesting/keeper/msg_server_test.go Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * Update x/vesting/spec/04_transactions.md Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * Update x/vesting/spec/04_transactions.md Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * Update x/vesting/spec/07_clients.md Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * Update x/vesting/types/msg.go Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * feature (vesting) changes in CLI client based on review comments * feature (vesting) add changes based on review comments * feature (vesting) add new funder blocked test case * feature (vesting) add validation new_funder != funder * feature (vesting) refactor error message for validation Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
…t to docs (#1091) * Add info about use of the home flag for the local_node.sh script to docs * Add reason why flag has to be added manually to commands * address linter Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
* add protolint yaml file * do not demand repeated field names to be plural * Make max line length 120 characters * Adjust protolint yaml reflecting PR comments * Specify protolint yaml in super-linter config * fix typo in .yml * Comment out linter rule to allow message to be called EndOfSupport
* erc20 OnRecv conversion * suggestions from pr * apply suggestions from pr * Change outward conversion to only accept coin denom * fix test inconsistency * suggestions from pr * suggestions from pr Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
* Fix unbound metrics and remove labels that keep increasing * Add entry to CHANGELOG * Update docs Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
) * Remove local copy of third party proto files * Update protogen scripts to work as the cosmos-sdk ones * Move protoc swagger script to scripts folder * Update protoc-swagger-gen.sh script to not use local copies of third party proto files * Commit updated go.mod & go.sum * Apply buf mod update after ethermint proto was uploaded to buf.build * Update makefile proto commands (except for proto-update-deps for now) * Add --network host to docker run command for linux compatibility * Cleanup buf yaml files * Update protocgen script to mirror working version in Ethermint repo * Update dependecy to use cosmos/gogoproto v1.4.3 * Commit generated files after updating protocgen script * add newlines to buf yaml files to address linter * make protoc-swagger-gen.sh executable * address shellcheck output * use cosmos/proto-builder docker image for proto-format * apply make proto-format * address more linter comments * comment out proto-swagger-gen and add todo * remove proto-swagger-gen from Makefile .PHONY * Use protolint for make proto-lint * Rename clang-format file so that it is used in make proto-format command * Sort Protobuf imports * Address protolint comments in all proto files * Generate Proto go implementations after adjusting proto files * address review comments Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
* docs(guides) add automated coin conversion guide * docs(guides) fix linting errors * docs(guides) fix linting errors * Update docs/developers/guides/automatic_coin_conversion.md Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * docs(guides) update based on PR comments * docs(guides) fix linting errors * docs(guides) add note message * Apply suggestions from code review Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * docs(guides) add line breaks to improve readability * docs(guides) rename guide file * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * docs(guides) update based on PR comments * docs(guides) add more examples * docs(guides) update based on PR comments Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/v10.0.x #1142 +/- ##
===================================================
+ Coverage 77.61% 78.45% +0.83%
===================================================
Files 128 130 +2
Lines 7500 7755 +255
===================================================
+ Hits 5821 6084 +263
+ Misses 1535 1522 -13
- Partials 144 149 +5
|
fix example json
danburck
approved these changes
Dec 5, 2022
danburck
reviewed
Dec 5, 2022
facs95
approved these changes
Dec 5, 2022
GAtom22
reviewed
Dec 5, 2022
|
|
||
| - (ante) [#1054](https://github.com/evmos/evmos/pull/1054) Remove validator commission `AnteHandler` decorator and replace it with the new `MinCommissionRate` staking parameter. |
There was a problem hiding this comment.
Nit: add the backslash to be consistent with the other bullets
Suggested change
| - (ante) [#1054](https://github.com/evmos/evmos/pull/1054) Remove validator commission `AnteHandler` decorator and replace it with the new `MinCommissionRate` staking parameter. | |
| - (ante) [\#1054](https://github.com/evmos/evmos/pull/1054) Remove validator commission `AnteHandler` decorator and replace it with the new `MinCommissionRate` staking parameter. |
| ### Improvements | ||
|
|
||
| - (ci) [#1138](https://github.com/evmos/evmos/pull/1138) Add Golang dependency vulnerability checker. |
There was a problem hiding this comment.
ditto
Suggested change
| - (ci) [#1138](https://github.com/evmos/evmos/pull/1138) Add Golang dependency vulnerability checker. | |
| - (ci) [\#1138](https://github.com/evmos/evmos/pull/1138) Add Golang dependency vulnerability checker. |
| - (go) [\#1039](https://github.com/evmos/evmos/pull/1039) Bump go v1.19 | ||
| - (deps) [\#1033](https://github.com/evmos/evmos/pull/1033) Bump Cosmos SDK to [`v0.46.4`](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.4) | ||
| - (test) [#1028](https://github.com/evmos/evmos/pull/1028) Add node upgrade end-to-end test suite. |
There was a problem hiding this comment.
ditto
Suggested change
| - (test) [#1028](https://github.com/evmos/evmos/pull/1028) Add node upgrade end-to-end test suite. | |
| - (test) [\#1028](https://github.com/evmos/evmos/pull/1028) Add node upgrade end-to-end test suite. |
| @@ -16,8 +16,7 @@ You can also use [chainlist.org](https://chainlist.org/) to add the node directl | |||
| ::: | |||
|
|
|||
| <!-- markdown-link-check-disable --> | |||
| :::: tabs | |||
| ::: tab Mainnet | |||
| ### Mainnet | |||
There was a problem hiding this comment.
Question: Were the tabs fixed? if so, I think we could leave the tabs
| @@ -16,8 +16,7 @@ Evmos offers two types block explorers: an EVM explorer and a Cosmos explorer. E | |||
|
|
|||
| Below is a list of public block explorers that support Evmos Mainnet and Testnet: | |||
|
|
|||
| :::: tabs | |||
| ::: tab Mainnet | |||
| 10000 | #### Mainnet | ||
There was a problem hiding this comment.
Q: ditto here about leaving the tabs
| ]; | ||
| // reward_scaler is the scaling factor for capping rewards | ||
| string reward_scaler = 4 | ||
| [(gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Dec", (gogoproto.nullable) = false]; | ||
| } |
There was a problem hiding this comment.
Nit: add blank line
Suggested change
| } | |
| } | |
| string description = 2; | ||
| // contract address | ||
| // contract address of the incentivized smart contract | ||
| string contract = 3; | ||
| } |
There was a problem hiding this comment.
Nit: ditto
Suggested change
| } | |
| } | |
| [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"]; | ||
| // vested defines the current amount of vested tokens | ||
| repeated cosmos.base.v1beta1.Coin vested = 3 | ||
| [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"]; | ||
| } |
There was a problem hiding this comment.
Nit: add blank line at EOF
Suggested change
| } | |
| } | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR takes all the changes from
mainand updates the upgrade handler for the new release located inapp/upgrades/v10/All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdCode maintenance:
I have...
godocand code comments.docs/) or specification (x/<module>/spec/)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...