Add pure ruby stub methods (raise EM::Unsupported) #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beee7d6 to
012c9e2
Compare
Many of these may be trivial to implement in pure ruby mode, and some may be impossible, but for right now I'd prefer to simply have them all displayed as a "TODO list" in the test results. _This would have broken many tests_ that were previously omitted based on whether or not `EM` responds to these methods. However an earlier commit marked those tests as pending in pure_ruby mode.
012c9e2 to
0a0e56f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extraction from (and a continuation of) #1006, which should be merged first.
Many of these may be trivial to implement in pure ruby mode, and some may be impossible, but for right now I'd prefer to simply have them all displayed as a "TODO list" in the test results.
This would have broken many tests that were previously omitted based on whether or not
EMresponds to these methods. However an earlier commit marked those tests as pending in pure_ruby mode.A minor tradeoff of this PR is that EM.respond_to?(method) cannot be used as a feature detection mechanism. However, it's my belief that it already can't be used reliably for that. Additionally, most of these methods are marked as
# @private, so users of EventMachine really should not make any assumptions about them. And fortunately, in my searches of public code, these are not the methods that people are checking.