Method report_connection_error_status is missing #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invoked. In the native (cpp) version, this method exists, but in the pure ruby version it does not. So when there is an undelivered message for example, it will attempt to check the socket status and fail saying that the report_connection_error_status does not exist. This in turn causes the connection to fail. report_connection_error_status will now return the socket status.
|
Thank you! Merged! |
sodabrew
pushed a commit
to sodabrew/eventmachine
that referenced
this pull request
Apr 30, 2018
…or (eventmachine#801) This method exists in the cpp version but not in the pure ruby version. When there is an undelivered message for example, it will attempt to check the socket status and fail saying that the method report_connection_error_status does not exist. This is in turn causes the connection to fail. It will not return the socket status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Connection::error?the methodEventMachine::report_connection_error_statusis invoked, which does not exist in the pure ruby version, but does exist in the native C++ version. This PR provides the equivalent pure ruby version ofEventMachine::report_connection_error_status