Add flag SSL_VERIFY_FAIL_IF_NO_PEER_CERT #655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e90c33 to
5916e70
Compare
|
Closing in favor of #665 |
|
Oh, right - can't forget about |
5916e70 to
1f673a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SSL_VERIFY_FAIL_IF_NO_PEER_CERT to resolve #299, #275, #195.
Add options for
start_tls(:ca_file..., :ca_path..., :private_key_pass...)to resolve #397, #378, #334, #84.Interesting discussion about needing extra depth information for
ssl_verify_peerathttps://github.com/eventmachine/eventmachine/pull/378/files#r2063643 - I wonder if there's a reasonable way to detect the arity of the callback before passing the extra arguments.