8000 Add TLS support to Java reactor by MattVonVielen · Pull Request #471 · eventmachine/eventmachine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add TLS support to Java reactor #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Add TLS support to Java reactor #471

wants to merge 27 commits into from

Conversation

Ma 8000 ttVonVielen
Copy link

This branch adds SSL/TLS support to the Java reactor. All ssl-related tests pass against JRuby (though there are still many unrelated test failures on JRuby which exist on master).

Addresses issues #34, #180, #379, and one line-item of #117

MattVonVielen and others added 27 commits October 2, 2013 13:24
@MattVonVielen
Fix errors in java build path file for eclipse
813a1f4
@MattVonVielen
Handle ssl handshake and verify events in ruby event handler
cc77e40
@MattVonVielen
EventableSocketChannel now knows whether it is a client or server cha…
832f068 
…nnel
@MattVonVielen
Introduce EventCallback interface
c9f885a
@MattVonVielen
Refactor several iterator-loops to foreach-loops
0995fee
@MattVonVielen
Convert constants to EventCode enum
7dbc2d3
@MattVonVielen
Convert interface to abstract class
e24c25a
@MattVonVielen
Pull binding property up
ff5cdf7
@MattVonVielen
Pull up selector field
7bc5b06
@MattVonVielen
Pull up outboundQ field
5807c6b
@MattVonVielen
Encapsulate reactor read logic in abstract/template class
15b3a1a
@MattVonVielen
Encapsulate reactor write logic in template class
1c6d3cc
@MattVonVielen
Encapsulate connectable logic into EventableSocketChannel
f1e2888
@MattVonVielen
Pull up unimplemented method into template class
e4ac4c7
@MattVonVielen
Answer true to '#ssl?'
b7e4398
@MattVonVielen
Convert tls params to java KeyStore and pass to reactor
bb765fa
@MattVonVielen
Pass TLS params to EventableSocketChannel
80097a9
@MattVonVielen
Introduce SslBox class
2f5b198
@MattVonVielen
Add ability to perform handshaking and fire events
072ade5
@MattVonVielen
Implement ssl_verify_peer callback
52b94ee
@MattVonVielen
Implement get_peer_cert
38fbd18
@MattVonVielen
Organize imports
b842793
@MattVonVielen
add java's bin directory to git ignore
7d28d94
@MattVonVielen
Better way to trigger OP_WRITE when handshaking
b5e6ce6
@MattVonVielen
Implement read/write through SslBox
81a0529
@MattVonVielen
Add SSL echo server test
02c013d
@MattVonVielen
Change HttpClient2 test so it won't hang on failure
cf67551
@swistaczek
Copy link

👍

@gregors
Copy link
gregors commented Jan 23, 2014

I'd love to see feedback on this. I'm assuming that failing test needs fixing before any discussion takes place?

@kennym
Copy link
kennym commented Feb 25, 2014

@gregors if you look at the details of the CI build you'll see that it rather timed out... Travis CI configuration needs to be fixed.

@ibc
Copy link
Contributor
ibc commented Feb 26, 2014

It is sad that pull requests like this one will be just ignored by EM developers.

@kennym
Copy link
kennym commented Feb 26, 2014

@ibc your effort with this fork https://github.com/ibc/EventMachine-LE is admirable. Kudos

@ps2
Copy link
Contributor
ps2 commented May 1, 2014

Anyone know why this isn't merged yet? I could take a swing at resolving any remaining issues if I knew what they were.

@kennym
Copy link
kennym commented May 1, 2014

EventMachine maintai 8000 ners do not accept any pull requests anymore. You will
have better luck with an actively maintained fork.

On Thu, May 1, 2014 at 2:50 PM, Pete Schwamb notifications@github.comwrote:

Anyone know why this isn't merged yet? I could take a swing at resolving
any remaining issues if I knew what they were.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/471#issuecomment-41943064
.

@portertech
Copy link
Contributor

Considering giving this a go. Could even live w/ a fork w/ "experimental" JRuby support.

@sodabrew sodabrew added this to the v1.2.0 milestone Feb 2, 2015
@sodabrew
Copy link
Member
sodabrew commented Feb 2, 2015

@xenolinguist Could I ask you to rebase this against current master?

@sodabrew sodabrew modified the milestones: v1.2.0, v1.2.1 Feb 25, 2016
@sodabrew sodabrew mentioned this pull request Nov 9, 2016
Merged
@sodabrew sodabrew modified the milestones: v1.2.1, v1.3.0 Nov 17, 2016
@sodabrew sodabrew modified the milestone: v1.3.0 Dec 6, 2016
@sodabrew sodabrew modified the milestones: v1.3.0, v1.4.0 Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
8 participants
@MattVonVielen @swistaczek @gregors @kennym @ibc @ps2 @portertech @sodabrew
0