Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 19 commits
- 24 files changed
- 5 contributors
Commits on Apr 23, 2018
Commits on Apr 30, 2018
-
The unbind callback must not raise exceptions
The unbind callback absolutely must not raise an exception or the reactor will crash. If there is no EM.error_handler, or if the error_handler retrows, then stop the reactor, stash the exception in $wrapped_exception, and the exception will be raised after the reactor is cleaned up (see the last line of self.run). This fixes many crash reports in the 1.2 series since #327 was merged.
-
-
-
-
Connection::error? calls report_connection_error_status in Ruby react…
…or (#801) This method exists in the cpp version but not in the pure ruby version. When there is an undelivered message for example, it will attempt to check the socket status and fail saying that the method report_connection_error_status does not exist. This is in turn causes the connection to fail. It will not return the socket status.
-
-
-
Remove using namespace std; and be explicit with std:: prefixes (#831)
This resolves the conflict of socket bind() vs std::bind(), as more std:: functions may be introduced in future versions of C++. Resolves #830
-
-
-
Commits on May 6, 2018
-
Fix crashes on large numbers of connections (#843)
All three fd_set arguments to select must be large enough to modify according to the length given BF4B in the first argument to select. This can be done by calling rb_fd_resize on each of the fd_set arguments, which happens to be exactly what rb_fd_select does!
Commits on May 12, 2018
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...1.2-stable