Try using super() to prevent recursion #750

asyncmind0 · 2022-02-22T01:50:20Z

No description provided.

codecov · 2022-02-22T08:21:06Z

Codecov Report

Merging #750 (dafc68f) into master (1f1f1ce) will increase coverage by 9%.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #750     +/-   ##
=======================================
+ Coverage      43%    53%     +9%     
=======================================
  Files          88     88             
  Lines       12342   9907   -2435     
  Branches     1803   1747     -56     
=======================================
- Hits         5421   5281    -140     
+ Misses       6516   4271   -2245     
+ Partials      405    355     -50

Flag	Coverage Δ
py27dnspython1	`54% <0%> (-1%)`	⬇️
py27epolls	`57% <0%> (-1%)`	⬇️
py27poll	`57% <0%> (-1%)`	⬇️
py27selects	`56% <0%> (-1%)`	⬇️
py35epolls	`50% <0%> (-1%)`	⬇️
py35poll	`50% <0%> (-1%)`	⬇️
py35selects	`50% <0%> (-1%)`	⬇️
py36epolls	`50% <0%> (-1%)`	⬇️
py36poll	`50% <0%> (-1%)`	⬇️
py36selects	`50% <0%> (-1%)`	⬇️
py38epolls	`?`
py38openssl	`?`
py38poll	`?`
py38selects	`?`
py39dnspython1	`?`
py39epolls	`?`
py39poll	`?`
py39selects	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
eventlet/green/ssl.py	`67% <0%> (+16%)`	⬆️
eventlet/green/OpenSSL/__init__.py	`71% <0%> (-29%)`	⬇️
eventlet/green/http/cookiejar.py	`0% <0%> (-1%)`	⬇️
eventlet/zipkin/api.py	`0% <0%> (ø)`
eventlet/zipkin/wsgi.py	`0% <0%> (ø)`
eventlet/hubs/pyevent.py	`0% <0%> (ø)`
eventlet/green/builtin.py	`0% <0%> (ø)`
eventlet/zipkin/client.py	`0% <0%> (ø)`
eventlet/green/asynchat.py	`0% <0%> (ø)`
eventlet/green/asyncore.py	`0% <0%> (ø)`
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1f1ce...dafc68f. Read the comment docs.

temoto · 2022-02-23T23:57:14Z

eventlet/green/ssl.py

-        _original_wrap_socket.__globals__['SSLContext'] = tmp_sslcontext
-        _original_sslsocket._create.__globals__['SSLSocket'] = tmp_sslsocket
+        _original_wrap_socket.__globals__["SSLContext"] = tmp_sslcontext
+        _original_sslsocket.sslsocket_class._create.__globals__[


please don't shrink it

there's max-line-width = 123 in tox.ini

if you want to introduce black formatter it's very much welcome in separate patch, with 123 width

itamarst · 2023-12-19T14:57:03Z

Can you explain the purpose of this PR? Thank you!

itamarst

Please explain the motivation for this PR, it's unclear to me.

asyncmind0 added 2 commits February 22, 2022 12:49

Try using super

ad259ba

Fix comment out old patch as this is now an enum

adefc69

Fix get _create from sslsocket_class

dafc68f

temoto reviewed Feb 23, 2022

View reviewed changes

itamarst requested changes Dec 22, 2023

View reviewed changes

asyncmind0 marked this pull request as draft February 5, 2024 02:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try using super() to prevent recursion #750

Try using super() to prevent recursion #750

Try using super() to prevent recursion #750

Are you sure you want to change the base?

Try using super() to prevent recursion #750

Conversation

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment