Make @unreleased mutually exclusive with @deprecated
#167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'm not sure this fits in this test file. This test file is for tags which aren't used on classes, when usage tags are something we could use on classes. It might be better to make a exclusive_tags test. What do you think?
There was a problem hiding this comment.
I think having a test file dedicated to classes with unused tags is too specific. A general exclusive_tags.luau file would be better, though the file should still contain this test case with the class.
There was a problem hiding this comment.
I do agree, we'll leave the PR as it is and treat this test case as exclusive tags. I could rename the tests sometime, but I'm not too worried about that really.
YetAnotherClown
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something is unreleased, then it can not be deprecated, since deprecation is to mark something as not supported once it is already in use.
Relevant discussion: https://discord.com/channels/385151591524597761/894395472582676502/1348417437514858587
Other queries:
@interfacecould be added, but this already errors due to "This tag is unused by X doc entries", which begs the question of whether explicit mutual exclusivity is really necessary.