Tags: evansb/kork
Tags
Revert "chore(dependencies): Upgrade Spring Cloud to Hoxton.SR1 (spin… …naker#455)" (spinnaker#517) This reverts commit 51e0197. With this change, `echo` and `clouddriver` (the two services that pick up `kork-config` module) fail to start with the following error: ``` org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'regionProvider' defined in class path resource [com/netflix/spinnaker/kork/configserver/autoconfig/SpringCloudAwsConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.cloud.aws.core.region.StaticRegionProvider]: Factory method 'environmentPropertiesAwsS3RegionProvider' threw exception; nested exception is java.lang.IllegalArgumentException: The region 'null' is not a valid region! ``` I tried to fix it by adding `ConditionalOnProperty` on `SpringCloudAwsConfiguration` but then it just failed with a bunch of other errors. I don't think it's OK for `kork` to create beans that are a) on by default and b) not turn-offable.
feat(secrets/secrets-manager): Add AWS Secrets Manager secret engine (s… …pinnaker#514) * feat(secrets/secrets-manager): Add AWS Secrets Manager secret engine * chore: Add copyright header * feat: add caching to SecretsManagerSecretEngine Co-authored-by: Justin Field <fieldju@gmail.com>
fix(swagger): Exclude MetaClass from swagger model generation (spinna… …ker#501) * fix(swagger): Exclude MetaClass from swagger model generation All groovy classes have an implicit metaClass field that handles metaprogramming. In cases where a groovy class is used in an API the springfox library to generate Swagger docs is including the metaClass in the model for the class. In addition to being confusing (as a producer/consumer of the API would never set that field), it also leads to terrible performance in some cases. The performance issues come from the fact that it then tries to build a model of MetaClass by reflecting its fields, etc. until it has built models of most of the Groovy classes. In particular, before this change, front50 took 140 seconds to start; with this change it now takes 13 seconds. * fix(swagger): Make groovy implementation dependency This does not need to be an API dependency. * fix(swagger): Only bring in core groovy We don't need all of it, only the core Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
fix(plugins): Pass through non-proxied extension class (spinnaker#511)
feat(plugins): Add ExtensionClassProvider to get proxied extension cl… …ass (spinnaker#509) * feat(plugins): Add ExtensionClassProvider to get proxied extension class * fix(plugins): Small tweak to improve test
refactor(plugins): Move plugins-api to api package (spinnaker#502)
fix(plugins): Update repository URL should be sourced via getOrElse c… …all (spinnaker#500)
PreviousNext