8000 Add Sungrow AC22E by andig · Pull Request #21676 · evcc-io/evcc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Sungrow AC22E #21676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Add Sungrow AC22E #21676

merged 1 commit into from
Jun 6, 2025

Conversation

andig
Copy link
Member
@andig andig commented Jun 6, 2025

No description provided.

@andig andig requested a review from premultiply June 6, 2025 11:04
@andig andig added the devices Specific device support label Jun 6, 2025
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andig - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@naltatis
Copy link
Member
naltatis commented Jun 6, 2025

Die haben scheinbar ihr Namensschema geändert. War erst irritiert über 011E vs 22E. Aber das scheint korrekt :D

@naltatis naltatis merged commit e3fd081 into master Jun 6, 2025
6 checks passed
@naltatis naltatis deleted the feat/sungrow branch June 6, 2025 11:13
@andig
Copy link
Member Author
andig commented Jun 6, 2025

Yes, isso.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0