-
-
Notifications
You must be signed in to change notification settings - Fork 916
Update sax.yaml #21277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sax.yaml #21277
Conversation
The port used in the template is wrong: must be 502 instead of 3600
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @oekinger - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Perhaps this change is depending on the Revision of the sax battery: I have a 2024 produced 7,7 kWh battery. Perhaps someone can verify if his/her sax works with port 3600 |
/cc @Sebreiter |
I have a 2023 produced5.2 kWh battery. My sax works with port 3600.
Modbus TCPmodbus: tcpip |
Ok, then we have a firmware dependency for the modbus port. Perhaps it’s enough to mention this in the description of the template? |
I guess the newer products might use the default port, so let's change it. |
To all you guys using a SAX Home with evcc:
I'm not familiar with github, so I'm not able to push the following snippet. Maybe someone of you guys can do this:
Regards Jürgen |
Can you please apply formatting? To edit, just open the file here in github and add your changes. Of course, these need be tested. |
Code snippet is now formatted. |
Please change the port used in the template becausre it is wrong: must be 502 instead of 3600.
Thanks,
Marko