Sungrow: Remove ChargeRater implementation #21115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @hameno - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
premultiply
approved these changes
May 7, 2025
The charged session energy resets on each start/stop command. evcc expects this to not reset until the car is disconnected. This breaks assumptions in loadpoint regarding the session charged energy and causes incorrect values to be calculated. Removing the implementation causes evcc to calculate the session energy based on the MeterEnergy implementation (total energy used by wallbox) which then correctly calculates session energy. Fixes evcc-io#19879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The charged session energy resets on each start/stop command. evcc expects this to not reset until the car is disconnected. This breaks assumptions in loadpoint regarding the session charged energy and causes incorrect values to be calculated.
Removing the implementation causes evcc to calculate the session energy based on the MeterEnergy implementation (total energy used by wallbox) which then correctly calculates session energy.
Fixes #19879