Plexlog: fix grid power #21061
Merged
Plexlog: fix grid power #21061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kommt aus #21017 Implementierung wurde damals ohne Batterie getestet. Mit Batterie ist Grid Wert fehlerhaft. Das wird hier korrigiert. Dank an @TobiasHuber1980 und @UH912 fürs testen.
There was a problem hiding this comment.
Hey @VolkerK62 - I've reviewed your changes - here's some feedback:
- Consider adding an inline comment explaining the purpose of
scale: -1for the battery power reading. - Should the new battery power Modbus reading be conditional, perhaps based on whether a battery is configured or the meter's usage?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Spricht hier irgendwas dagegen hier auch das normale Modbus-Template statt uri:port zu verwenden? |
|
keine Ahnung, vermutlich nicht. |
|
Wenn mir jemand sagt was ich testen soll, dann nur her damit... |
|
aktuelles nightly 0.203.5+1746585508
|
|
Das ist doof. |
|
Ich hab es kaputt gemacht. Es ist auch eigentlich nicht BC... Fix kommt. |
|
Fixed by dbf5632 |
yes - funktioniert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kommt aus #21017
Implementierung wurde damals ohne Batterie getestet. Mit Batterie ist Grid Wert fehlerhaft. Das wird hier korrigiert.
Dank an @TobiasHuber1980 und @UH912 fürs testen.