8000 Shelly: add missing PM1 condition by thierolm · Pull Request #20919 · evcc-io/evcc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Shelly: add missing PM1 condition #20919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

Shelly: add missing PM1 condition #20919

merged 2 commits into from
Apr 28, 2025

Conversation

thierolm
Copy link
Contributor
@thierolm thierolm commented Apr 28, 2025 •
edited by sourcery-ai bot
Loading

Fixes #20866

Summary by Sourcery

Bug Fixes:

  • Fix missing power, energy, current, and voltage readings for Shelly Gen2 devices identified primarily by a PM1 endpoint rather than a Switch endpoint.

@sourcery-ai Sourcery AI
Copy link
Contributor
sourcery-ai bot commented Apr 28, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request adds the missing condition for the PM1 endpoint to several data retrieval methods for Shelly Gen2 devices. Previously, these methods only considered the switch endpoint, but now they correctly include the PM1 endpoint as well.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Include PM1 endpoint condition in data retrieval logic.
  • Added PM1 endpoint check in CurrentPower function.
  • Added PM1 endpoint check in TotalEnergy function.
  • Added PM1 endpoint check in Currents function.
  • Added PM1 endpoint check in Voltages function.
  • Added PM1 endpoint check in Powers function.
 meter/shelly/gen2.go

Assessment against linked issues

Issue Objective Addressed Explanation
#20866 The Shelly device stopped being recognized and integrated as a balcony power station after version 203.01 of evcc. ✅

Possibly linked issues

  • Shelle PM Mini Gen3 #20866: The PR adds the missing PM1 endpoint condition to the Shelly Gen2 meter code, which likely fixes the issue with the Shelly PM Mini Gen3.
  • Shelle PM Mini Gen3 #20866: The PR adds a missing PM1 condition to fix incorrect energy values reported by Shelly EM.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thierolm - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider abstracting the shared logic for Switch and PM1 endpoints to avoid repeating the || c.hasPM1Endpoint() condition in multiple methods.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

This was referenced Apr 28, 2025
Closed
Closed
@andig andig merged commit 5eff3d9 into evcc-io:master Apr 28, 2025
6 checks passed
@thierolm thierolm deleted the shelly/re-enable_shelly_mini_pm branch April 28, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shelle PM Mini Gen3
2 participants
@thierolm @andig
0