8000 KEBA: Compensate incorrect energy reporting for P40 by breiti · Pull Request #20907 · evcc-io/evcc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

KEBA: Compensate incorrect energy reporting for P40 #20907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2025
Merged

KEBA: Compensate incorrect energy reporting for P40 #20907

merged 1 commit into from
Apr 27, 2025

Conversation

breiti
Copy link
Contributor
@breiti breiti commented Apr 27, 2025 •
edited by sourcery-ai bot
Loading

The documentation of the KEBA P40 wallbox states that the energy values are falsely reported in "Wh" (Watt hours) instead of "0.1 Wh" for versions below 1.2.1, which is not yet released.

This commit adds a workaround for all current versions of the KEBA P40.

Summary by Sourcery

Bug Fixes:

  • Correct the energy scaling factor for Keba P40 firmware versions below 1.2.1, which report values in Wh instead of 0.1 Wh.

@sourcery-ai Sourcery AI
Copy link
Contributor
sourcery-ai bot commented Apr 27, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request implements a workaround for the KEBA P40 wallbox to correctly report energy values. It reads the device's firmware version and adjusts the scaling factor used for energy calculations based on whether the firmware is older than version 1.2.1, which is known to report energy incorrectly.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add an energy scaling factor and adjust it based on P40 firmware version.
  • Add a new field energyFactor to the Keba struct.
  • Initialize energyFactor to a default value.
  • Read the firmware version for P40 models.
  • Check if the firmware version is below 1.2.1.
  • Set energyFactor to a different value if the firmware is older than 1.2.1.
  • Use the energyFactor when calculating the total energy.
 charger/keba-modbus.go
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 27, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @breiti - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider defining the firmware version threshold 10201 as a named constant to improve readability.
  • If reading the firmware version fails for a P40, the energy factor defaults to 1e4; should it default to 1e3 instead, as the description implies all current P40 versions are affected by the bug?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@breiti breiti force-pushed the feature/p40-knownbugs branch from 43ddbf8 to 0383056 Compare April 27, 2025 16:30
andig
andig reviewed Apr 27, 2025
View reviewed changes
@andig andig added the devices Specific device support label Apr 27, 2025
@breiti breiti force-pushed the feature/p40-knownbugs branch from 0383056 to b1b7d32 Compare April 27, 2025 17:43
andig
andig reviewed Apr 27, 2025
View reviewed changes
@breiti
KEBA: Compensate incorrect energy reporting for P40
86f510f 
The documentation of the KEBA P40 wallbox states that the energy values are
falsely reported in "Wh" (Watt hours) instead of "0.1 Wh" for versions below
1.2.1, which is not yet released.

This commit adds a workaround for all current versions of the KEBA P40.
@breiti breiti force-pushed the feature/p40-knownbugs branch from b1b7d32 to 86f510f Compare April 27, 2025 18:00
@andig andig merged commit 3b7680f into evcc-io:master Apr 27, 2025
6 checks passed
@breiti breiti deleted the feature/p40-knownbugs branch April 27, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig andig left review comments

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@premultiply premultiply

Labels
devices Specific device support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breiti @andig @premultiply
0