KEBA: Add support for KeContact P40 charger #20860
Conversation
The modbus implementation for the KeContact P40 is mostly the same as
for the P30 devices. There are some differences:
- The "Product type and features" register (1016) has a slightly
different layout.
- Enabling/disabling needs to be done by setting the maximum
current to 0, which is not supported by the P30 devices.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the KeContact P40 charger by extending the existing modbus implementation.
- Updates the charger definition YAML to include the P40 models.
- Modifies the modbus connection handling to determine P40 devices based on product code, updating the register used for enabling/disabling accordingly.
- Adds new fields and logic in the Go module to manage current values and enable registers specific to the P40 charger.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| templates/definition/charger/keba-modbus.yaml | Adds support for KeContact P40 by introducing a separate product entry. |
| charger/keba-modbus.go | Extends product code handling to distinguish between P30 and P40, and updates enable logic for P40. |
Comments suppressed due to low confidence (1)
charger/keba-modbus.go:45
- [nitpick] Consider renaming the field 'regEnable' to 'enableRegister' for improved clarity and consistency with other register naming conventions.
regEnable uint16
|
I've tested this with P40 & P30 wallboxes - seems to work fine, thanks @breiti 👍🏻 Now the only thing left to have a fully working P40 Modbus setup is that Keba fixes the register "Charged energy"(1502) in their Firmware. |
|
I've already prepared a fix for this in evcc, but I need to test this today. |
|
@breiti https://docs.evcc.io/docs/devices/chargers#kecontact-p40-p40-pro |
|
PR welcome. |
|
@breiti top, vielen Dank! |
The modbus implementation for the KeContact P40 is mostly the same as for the P30 devices. There are some differences:
The "Product type and features" register (1016) has a slightly different layout.
Enabling/disabling needs to be done by setting the maximum current to 0, which is not supported by the P30 devices.