8000 Vehicles: move more properties to /vehicles (BC) by andig · Pull Request #11181 · evcc-io/evcc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Vehicles: move more properties to /vehicles (BC) #11181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 20, 2024
Merged

Vehicles: move more properties to /vehicles (BC) #11181

merged 8 commits into from
Jan 20, 2024

Conversation

andig
Copy link
Member
@andig andig commented Dec 22, 2023 •
edited
Loading

Refs #11023

This PR moves all vehicle settings output from loadpoint to vehicles. This affects icon, capacity and features.

TODO

Out of scope:

  • decide connector or group or drop this feature altogether
  • implement connector/group if desired
  • move vehicle state from loadpoint to vehicles

@andig andig requested a review from naltatis December 22, 2023 16:02
@andig andig marked this pull request as draft December 22, 2023 16:02
@andig andig added the enhancement New feature or request label Dec 22, 2023
@MarkusGH
Copy link
Contributor
MarkusGH commented Dec 22, 2023 •
edited
Loading
  • decide connector or group or drop this feature altogether

Ich plädiere stark für "group" - denn das Feature ist allgemeiner nutzbar als nur für "Steckertyp".
Außerdem wäre es super z. B. die Auswahl des Gastfahrzeugs an bestimmten Ladepunkten verhindern zu können.

@andig andig force-pushed the feature/cleanup-vehicle branch from f62a3cd to c8c8667 Compare December 27, 2023 15:35
@andig andig mentioned this pull request Dec 28, 2023
Closed
@andig
Copy link
Member Author
andig commented Jan 10, 2024

@naltatis hast Du den PR hier noch auf dem Radar?

@naltatis
Copy link
Member

Ja

@andig andig force-pushed the feature/cleanup-vehicle branch from 00fe6ce to 5e3d769 Compare January 15, 2024 20:13
@andig
Copy link
Member Author
andig commented Jan 15, 2024

Rebased

@naltatis naltatis marked this pull request as ready for review January 17, 2024 11:58
naltatis
naltatis approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member
@naltatis naltatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt soweit. Fehlt nur noch der Push Ersatz.

@andig andig force-pushed the feature/cleanup-vehicle branch from a2b364e to 9b535c9 Compare January 20, 2024 09:04
@andig andig changed the title Vehicles: move more properties to /vehicles Vehicles: move more properties to /vehicles (BC) Jan 20, 2024
andig
andig commented Jan 20, 2024
View reviewed changes
andig
andig commented Jan 20, 2024
View reviewed changes
@andig andig requested a review from naltatis January 20, 2024 09:12
@andig
Copy link
Member Author
andig commented Jan 20, 2024

Wäre noch schön, den vor #9812 rein zu bekommen.

@andig andig merged commit bc0343a into master Jan 20, 2024
@andig andig deleted the feature/cleanup-vehicle branch January 20, 2024 11:19
@VolkerK62
Copy link
Contributor

This affects icon, capacity and features.

Da es die in der yaml am Loadpoint nicht gibt, muss man am Charger etwas ändern?
(oder bin ich auf dem völlig falschen Weg?)

@andig
Copy link
Member Author
andig commented Jan 20, 2024

Betrifft nur http und mqtt Apis

naltatis pushed a commit that referenced this pull request Jan 25, 2024
@andig @naltatis
Vehicles: move more 88AA properties to /vehicles (BC) (#11181)
f2d4e9b
@binderth binderth mentioned this pull request Feb 7, 2024
Closed
@andig andig mentioned this pull request Mar 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naltatis naltatis naltatis approved these changes

Assignees

@naltatis naltatis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andig @MarkusGH @naltatis @VolkerK62
0