8000 Fix Version sorting putting versions like 4.0 after 4.0.1 by Cammymoop · Pull Request #81 · eumario/godot-manager · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fi 8000 x Version sorting putting versions like 4.0 after 4.0.1 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix Version sorting putting versions like 4.0 after 4.0.1 #81

merged 1 commit into from
Apr 1, 2024

Conversation

Cammymoop
Copy link
Contributor
@Cammymoop Cammymoop commented Feb 21, 2024 •
edited
Loading

Fixes #80
Sorts based on the SemVer spec mostly, only a few differences.

  • Supports Versions with only 2 numbers like godot uses (4.2 instead of 4.2.0)
  • Ignores a "v" at the start of the tag
  • Ignores any string following a valid version (doesn't need "+")
  • If the version tag has no valid version string it will sort below all valid versions
  • Invalid versions sort by simply comparing the version tag strings
  • Official github builds include -stable this technically marks it as a pre-release but it's alphabetically after stuff like -alpha and -dev so it doesn't need any special handling to just work.

Before/After
bfaf

Also in the Godot Versions page
ApplicationFrameHost_96SPTAqRnA

@Cammymoop Cammymoop force-pushed the proper-version-sort branch 2 times, most recently from 7214df0 to 58d8ea8 Compare February 21, 2024 05:49
@Cammymoop
Copy link
Contributor Author

I noticed that the rewrite for 0.3 includes semver functionality, so this is probably just a 0.2 thing

@eumario eumario merged commit f29db9f into eumario:master Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eumario eumario eumario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version sorting Incorrectly sorts versions with only 2 numbers
2 participants
@Cammymoop @eumario
0