Fixes a crash when a project is missing a name. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eumario
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Since Godot allows you to just create an empty project.godot, this can happen. It should really see if the size of the file is 0, and if so, populate with Basic information. Approving this as this shouldn't be needed, but more then likely is, cause Godot may not save config/name in the application section, if it is empty in the Project Settings dialog.
|
Please make sure to create a PR against Godot 4 Tree for this fix as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw there's also a godot4 branch. I can also port this to godot4 as well.
output.mp4