8000 UI CHANGES by mufarrah · Pull Request #5 · ethicnology/dispute · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 12, 2024. It is now read-only.

UI CHANGES #5

Merged
merged 7 commits into from
Feb 4, 2023
Merged

UI CHANGES #5

merged 7 commits into from
Feb 4, 2023

Conversation

mufarrah
Copy link
Contributor
@mufarrah mufarrah commented Feb 2, 2023

Hi man

I like the work your doing here ..

done some basic ui changes such as :

  1. Added Material 3.
  2. Added google fonts and used "poppins".
  3. changed the forms layout
  4. added background color for submission buttons.
  5. changed the floatingActionButtons design.

Screenshot_20230203_011342

Screenshot_20230203_011404

If you like the changes , then please merge.
thanks , and would like to collab working on ui.

@ethicnology
Copy link
Owner

Appreciated, I will take a look when I have free time

Thank you

@ethicnology ethicnology changed the base branch from main to develop February 3, 2023 14:07
Copy link
Owner
@ethicnology ethicnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need further informations

< 8000 !-- -->

borderRadius: BorderRadius.all(Radius.circular(10)),
)),

// decoration: const InputDecoration(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove commented code if you find it useless

@@ -5,6 +5,8 @@
import FlutterMacOS
import Foundation

import path_provider_foundation
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain me these changes

@ethicnology
Copy link
Owner

When you will commit your modifications, use:

git commit --amend

While amending your commit please rename it using the conventional commit standard: refactor: UI changes

@ethicnology
Copy link
Owner

The previous relay was down that's why no messages are loaded in your screenshot.

On the develop branch i replaced the default relay, you should be able to receive the nostr events, now

@mufarrah May i ask could you take a deeper look at the UI and use your magic to improve it ?
(adding as less dependencies as possible)

Your skills are appreciated here

@ethicnology
Copy link
Owner

@mufarrah Your contribution is really appreciated, thanks

Sorry, something went wrong.

@ethicnology ethicnology merged commit e27a4b9 into ethicnology:develop Feb 4, 2023
@mufarrah mufarrah deleted the develop branch February 4, 2023 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0