8000 feat: cache error and null result formatters by BobTheBuidler · Pull Request #3703 · ethereum/web3.py · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: cache error and null result formatters #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: cache error and null result formatters #3703

wants to merge 2 commits into from

Conversation

BobTheBuidler
Copy link
Contributor

What was wrong?

When u 8000 sing the default formatters, we can cache the callable for re-use instead of rebuilding it every time it is used.

Related to Issue #
Closes #

How was it fixed?

A simple dict-based cache

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@BobTheBuidler
Copy link
Contributor Author
BobTheBuidler commented May 19, 2025 •
edited
Loading

I didn't implement this for the successful result formatters since the key is a little more complex and I'm not entirely sure how Module works here, but thinking I should do that as well. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3CD2
Development

Successfully merging this pull request may close these issues.
1 participant
@BobTheBuidler
0