This repository was archived by the owner on May 23, 2023. It is now read-only.
compile_code: raise exception when solc missing #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When solc is not installed, compile_code() would end up using None as the first element in the args list passed to subprocess.Popen(), causing it to crash with an AttributeError. This fixes that
konradkonrad
added a commit
that referenced
this pull request
Mar 3, 2017
Changelog/PRs: - #423: "State snapshot module" - #425: "Wrap encode_hex to support changes to pyrlp 0.4.7" - #428: "fix memory leak in vm" - #431: "compile_code: raise exception when solc missing" - #433: "fix genesis timestamp" - #434: "Adjust to pysha3 breaking changes" - #435: "Fix solidity combinedjson" - #438: "Install solc from zip" - #439: "Shouldn't have a number equal to 2^256 in EVM" - #441: "Always install solidity dependencies"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When solc is not installed, compile_code() would end up using None as the first element in the args list passed to subprocess.Popen(), causing it to crash with an AttributeError. This fixes that