More info when database is missing a node, plus related pruning bugfix #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I wasn't sure circle was going to run on a draft |
076e35a to
e6ff7da
Compare
Merged
pipermerriam
approved these changes
Mar 18, 2019
trie/hexary.py
Outdated
| node_type = get_node_type(node) | ||
|
|
||
| # node is mutable, so capture the key for later pruning now | ||
| prune_key = self._get_prune_key(node) |
There was a problem hiding this comment.
This seems like potential for forgetting, what about something like:
with self._prune_node(node):
... # do things that might raise errorsThe pruning would only happen if the context exits without exception.
There was a problem hiding this comment.
Argh, how did I miss that. Thanks!
| # Prune only if no exception is raised | ||
| try: | ||
| yield | ||
| except: |
There was a problem hiding this comment.
I don't think you need this try/except block at all (and we probably end up taking a performance hit for it).
try:
thing()
except:
raise
else:
something()
# equivalent to
thing()
something()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When a node in the trie was missing, we:
How was it fixed?
TODO
Cute Animal Picture