precompiles: Use classic EC point add formula #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8277d57 to
c1912b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1165 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 169 169
Lines 18004 18020 +16
=======================================
+ Hits 17011 17027 +16
Misses 993 993
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
rodiazet
approved these changes
Mar 14, 2025
Comment on lines
131
to
133
| template <typename IntT, int A = 0> | ||
| ProjPoint<IntT> add(const evmmax::ModArith<IntT>& s, const ProjPoint<IntT>& p, | ||
| const ProjPoint<IntT>& q, const IntT& b3) noexcept |
There was a problem hiding this comment.
Why not drop it if we have general formula?
There was a problem hiding this comment.
Still needed for multiplication where projective coordinates are used.
c1912b0 to
3abbcc7
Compare
gumb0
pushed a commit
that referenced
this pull request
Mar 20, 2025
This makes the BN254 `ecadd` precompile 30% faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions
2EA1
on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the BN254
ecaddprecompile 30% faster.