Add EIP: Set MAX_RECEIPTS_MESSAGE_SIZE for GetReceipts in devp2p #9892
Conversation
File
|
a84905f to
5339c1d
Compare
GetReceipts in DevP2PThere was a problem hiding this comment.
I think this particular proposal is kind of dangerous? If a block is mined that exceed the receipt limit this would make it impossible to perform a sync of the chain because when you request the block over p2p you would get the greater than 15MiB limit.
Would a better solution be to paginate the request? Basically would need new request / response methods that allo finer grained access of receipts per block hash.
why would the block be 15 MiB? the block limit will still be at 10 MiB. this only increase the maximum size for receipts + this concern is completely gone with EIP-7934 |
Pagination does not work because you can exploit the unlimited |
|
Thank you really appreciated Sent from my iPhoneOn Jun 12, 2025, at 4:38 AM, Giulio rebuffo ***@***.***> wrote:Giulio2002 left a comment (ethereum/EIPs#9892)
Would a better solution be to paginate the request? Basically would need new request / response methods that allo finer grained access of receipts per block hash.
Pagination does not work because you can exploit the unlimited receipt.data field and filling it with high entropy stuff that cannot be compressed
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
|
The commit 97d032b (as a parent of 5b676f4) contains errors. |
|
@Giulio2002 let know when the issues flagged by the bot are addressed and this PR is draft ready |
ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS
--
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: