8000 golangci-lint-action from 6.3.2 to 8.0.0 by kei01234kei · Pull Request #299 · etcd-io/raft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

golangci-lint-action from 6.3.2 to 8.0.0 #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

golangci-lint-action from 6.3.2 to 8.0.0 #299

wants to merge 11 commits into from
+55 −38

Conversation

kei01234kei
Copy link
@kei01234kei kei01234kei commented May 26, 2025 •
edited
Loading

This CI has failed due to the late version of golang ci lint. So I updated it.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kei01234kei
Once this PR has been reviewed and has the lgtm label, please assign ptabor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @kei01234kei. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kei01234kei kei01234kei force-pushed the update_golang_ci_lint_to_2_1_6 branch from 17b4dec to 6a3b5d9 Compare May 26, 2025 13:30
@kei01234kei kei01234kei changed the title update golang ci lint to 2.1.6 golangci-lint-action from 6.3.2 to 8.0.0 May 26, 2025
@ahrtr
Copy link
Member
ahrtr commented Jun 17, 2025

/ok-to-test

@kei01234kei kei01234kei force-pushed the update_golang_ci_lint_to_2_1_6 branch from 9679260 to 986ce55 Compare June 25, 2025 10:58
kei01234kei added 10 commits June 25, 2025 22:42
@kei01234kei
update golang ci lint to 2.1.6
cba3d2e 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei
update golangci-lint-action to 8.0.0
7a02188 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei
delete skip-files
8b19a90 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei < 8000 /div>
delete formatters
e21908d 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei
golangci-lint migrate
8733fbf 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei
enable gci formatter
72b8a14 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei
set run.timeout into 30m
1390de6 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei
add comment
bc487b7 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei
omit QF1008 check
ecf2c0b 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei
does not need to include ST1019 checks because staticcheck uses check…
2746d16 
…s all

Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei kei01234kei force-pushed the update_golang_ci_lint_to_2_1_6 branch from a62412b to 2746d16 Compare June 25, 2025 13:42
@kei01234kei
add checks to ommit
7d98cd1 
Signed-off-by: Keisuke Ishigami <k.130.email@gmail.com>
@kei01234kei kei01234kei force-pushed the update_golang_ci_lint_to_2_1_6 branch from 369ae08 to 7d98cd1 Compare June 25, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kei01234kei @k8s-ci-robot @ahrtr
0