Add request timeouts to prevent code freezes #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- Enable the ruff rule to prevent using requests without a timeout. The rule doesn't catch all the cases, but it's a best effort.
- Add missing timeouts where I am pretty confident about them.
- Leave TODOs where it would take me too much time to test and decide what the adequate timeout is.
- Enable the ruff rule to prevent using requests without a timeout. The rule doesn't catch all the cases, but it's a best effort. - Add missing timeouts where I am pretty confident about them. - Leave TODOs where it would take me too much time to test and decide what the adequate timeout is.
TheBits
reviewed
Apr 17, 2024
TheBits
approved these changes
Apr 17, 2024
Co-authored-by: Sergey Mezentsev <sergeyme@dstack.ai>
Bihan
pushed a commit
to SMTM-Capital/dstack
that referenced
this pull request
Apr 30, 2024
* Add request timeouts to prevent code freezes - Enable the ruff rule to prevent using requests without a timeout. The rule doesn't catch all the cases, but it's a best effort. - Add missing timeouts where I am pretty confident about them. - Leave TODOs where it would take me too much time to test and decide what the adequate timeout is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.