Support matching recordings using a URI regex #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - thanks for reviving. Those two equality unit tests are failing it seems. |
|
I suspected there might be something wrong. The day job blocks Travis CI (who knows why). Pretty sure the unit tests pass when I run it through Xcode, but I'll investigate and get a fix pushed up. |
Regex-based recordings use a different key (“uri-regex”) from exact match recordings. When recordings are added to a cassette, those that match on a regex are stored in a separate array instead of the VCRRequestKey-based dictionary. I’m keeping the regex in a separate property on VCRRecording, too, and it’s stored as an NSRegularExpression instance instead of NSString so we don’t have to rebuild the instances on every network request.
|
Excellent! Thanks for adding this feature! |
|
Thanks @sjmadsen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revives the work that @epologee started in #24. I cherry picked his commits, then made additional changes to address the suggestions made by @dstnbrkr.