Escape slash inside bracket expression #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many AWK implementations appears to allow unescaped slashes inside a bracket expression in a regular expression literal, consistent with the way that most metacharacters lose their meaning inside bracket expressions (tested: GNU Awk 4.2.1, mawk 1.3.4, and BWK awk (nawk) 20121220, all on Arch Linux); however, some versions also appear to require such a slash to be escaped (tested: mawk 1.3.3 on Debian Stretch), and this appears to be consistent with POSIX, which in the Lexical Conventions, number 6, states that “[a]n ERE constant shall be terminated by the first unescaped occurrence of the <slash> character after the one that begins the ERE constant.” Escaping the slash appears to be safe in all tested versions (that is, it does not count the backslash as part of the bracket expression), so let’s do that to ensure the program also works with mawk 1.3.3 on Debian Stretch, fixing dspinellis#7.
|
@fanis can you check if this solves the problem for you? |
|
After escaping that slash: Ensuring I got the change right: |
|
I’m getting the same “FAIL pmonitor: expected 50, got ''” both on this commit and on the parent (current |
|
(#11 should fix the second error message.) |
|
This is yet to be merged! |
|
To clarify: it's not just the test suite that fails for me. |
|
Yup: |
|
Hm, then I’m not sure where this error could come from. Which shell is your |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many AWK implementations appears to allow unescaped slashes inside a bracket expression in a regular expression literal, consistent with the way that most metacharacters lose their meaning inside bracket expressions (tested: GNU Awk 4.2.1, mawk 1.3.4, and BWK awk (nawk) 20121220, all on Arch Linux); however, some versions also appear to require such a slash to be escaped (tested: mawk 1.3.3 on Debian Stretch), and this appears to be consistent with POSIX, which in the Lexical Conventions, number 6, states that “[a]n ERE constant shall be terminated by the first unescaped occurrence of the character after the one that begins the ERE constant.” Escaping the slash appears to be safe in all tested versions (that is, it does not count the backslash as part of the bracket expression), so let’s do that to ensure the program also works with mawk 1.3.3 on Debian Stretch, fixing #7.