8000 ADOrganizationalUnit: add property "RestoreFromRecycleBin" to ignorelist by svenboll · Pull Request #664 · dsccommunity/ActiveDirectoryDsc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ADOrganizationalUnit: add property "RestoreFromRecycleBin" to ignorelist #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 1, 2022
Merged

ADOrganizationalUnit: add property "RestoreFromRecycleBin" to ignorelist #664

merged 4 commits into from
May 1, 2022

Conversation

svenboll
Copy link
Contributor
@svenboll svenboll commented Aug 20, 2021 •
edited
Loading

Pull Request (PR) description

addtional fix to not check parameter "RestoreFromRecycleBin" if it is in desired state.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@svenboll svenboll changed the title Fix ADOrganizationalUnit to ignore property "RestoreFromRecycleBin" ADOrganizationalUnit: add property "RestoreFromRecycleBin" to ignorelist Aug 20, 2021
@svenboll svenboll marked this pull request as ready for review August 20, 2021 17:20
@codecov
Copy link
codecov bot commented Aug 20, 2021 •
edited
Loading

Codecov Report

Merging #664 (44c5591) into main (8d2d716) will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #664   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3408           
===================================
  Hits       3340   3340           
  Misses       68     68
Impacted Files Coverage Δ
...DOrganizationalUnit/MSFT_ADOrganizationalUnit.psm1 100% <100%> (ø)

@johlju johlju added the needs review The pull request needs a code review. label Aug 25, 2021
@johlju
Copy link
Member
johlju commented May 1, 2022

Thanks for this! 🙂 I added a test to this to verify the error and that it has been solved with the proposed change.

johlju
johlju approved these changes May 1, 2022
View reviewed changes
Copy link
Member
@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @svenboll)

@johlju johlju merged commit 04f5f39 into dsccommunity:main May 1, 2022
@johlju johlju removed the needs review The pull request needs a code review. label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenboll @johlju
0