support eth_subscribe newPendingTransactionsWithBody #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirillPamPam
reviewed
Jun 5, 2025
| currentUpstream.getIngressReader().read(request) | ||
| .timeout(Defaults.internalCallsTimeout) | ||
| .map { response -> | ||
| Global.objectMapper.readValue(response.getResult(), Transaction::class.java) |
There was a problem hiding this comment.
I think it's better to avoid unnecessary serialization if there is no result (in that case there is an error). Otherwise there will be an error, but by adding a check we can return Mono.empty immediately
KirillPamPam
approved these changes
Jun 5, 2025
4773eb6 to
22530d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.