8000 fix: [CI-15731]: Refactor Bitrise Environment Variable Handling for Dynamic Defaults by Ompragash · Pull Request #35 · drone/plugin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: [CI-15731]: Refactor Bitrise Environment Variable Handling for Dynamic Defaults #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. 8000 We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: [CI-15731]: Refactor Bitrise Environment Variable Handling for Dynamic Defaults #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93e1124
fix: [CI-15731]: Refactor Bitrise Environment Variable Handling for D…
Ompragash Jan 16, 2025
e393e4e
Updated environ.go
Ompragash Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions plugin/bitrise/environ.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,21 @@ func Environ(src []string) []string {
}
}

bitriseDefaults := map[string]string{
"BITRISEIO_FINISHED_STAGES": "",
"BITRISE_DEPLOY_DIR": "",
"BITRISE_APP_TITLE": "",
"BITRISE_APP_URL": "",
"BITRISE_APP_SLUG": "",
"BITRISE_PROVISION_URL": "",
"BITRISE_CERTIFICATE_URL": "",
"BITRISE_CERTIFICATE_PASSPHRASE": "",
}

for key := range bitriseDefaults {
dst[key] = firstMatch(dst, key)
}
< 9F78 br>
// bitrise plugins may depend on bitrise environment variables.
// map drone environment variables, which are already present
// in the execution envionment, to their bitrise equivalents.
Expand Down Expand Up @@ -59,7 +74,6 @@ func Environ(src []string) []string {
"BITRISEIO_PULL_REQUEST_HEAD_BRANCH": dst["DRONE_TARGET_BRANCH"],
"BITRISEIO_PIPELINE_ID": firstMatch(dst, "HARNESS_PIPELINE_ID", "DRONE_STAGE_NAME"),
"BITRISEIO_PIPELINE_TITLE": firstMatch(dst, "HARNESS_PIPELINE_ID", "DRONE_STAGE_NAME"),
"BITRISEIO_FINISHED_STAGES": "", // TODO
"BITRISE_GIT_BRANCH": dst["DRONE_BRANCH"],
"BITRISE_GIT_TAG": dst["DRONE_TAG"],
"BITRISE_GIT_COMMIT": dst["DRONE_COMMIT_SHA"],
Expand All @@ -69,16 +83,9 @@ func Environ(src []string) []string {
"BITRISE_BUILD_TRIGGER_TIMESTAMP": dst["DRONE_BUILD_CREATED"], // MISSING IN HARNESS
"BITRISE_BUILD_URL": dst["DRONE_BUILD_LINK"], // MISSING IN HARNESS
"BITRISE_PULL_REQUEST": dst["DRONE_PULL_REQUEST"], // MISSING IN HARNESS
"BITRISE_SOURCE_DIR": firstMatch(dst, "DRONE_WORKSPACE", "HARNESS_WORKSPACE"), // MISSING IN HARNESS
"BITRISE_DEPLOY_DIR": "", // TODO
"BITRISE_SOURCE_DIR": firstMatch(dst, "DRONE_WORKSPACE", "HARNESS_WORKSPACE"), // MISSING IN HARNESS // TODO
"BITRISE_TRIGGERED_WORKFLOW_ID": dst["HARNESS_PIPELINE_ID"],
"BITRISE_TRIGGERED_WORKFLOW_TITLE": dst["HARNESS_PIPELINE_ID"],
"BITRISE_APP_TITLE": "", // TODO
"BITRISE_APP_URL": "", // TODO
"BITRISE_APP_SLUG": "", // TODO
"BITRISE_PROVISION_URL": "", // TODO
"BITRISE_CERTIFICATE_URL": "", // TODO
"BITRISE_CERTIFICATE_PASSPHRASE": "", // TODO
})

// is pipeline a pull request?
Expand Down
0