8000 V1 by shshaw · Pull Request #54 · drien/jquery-flipster · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

V1 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 69 commits into from
Oct 23, 2015
Merged

V1 #54

merged 69 commits into from
Oct 23, 2015

Conversation

shshaw
Copy link
Collaborator
@shshaw shshaw commented May 21, 2015

Starting the discussion here for 1.0.

Adrien Delessert and others added 30 commits March 17, 2015 23:46
Add autoplay feature
2a31b09
Remove half baked compatibility mode
0a961b7
Favor returning early to decrease indents
7d1020e
Pass items with onItemSwitch callback
f572541
Prevent onItemSwitch callback when window is resized
b02a657
Fix vertical scrolling bug on touch devices
44720c0
Clean up and rename variables for easier reading/refactoring
f9809e3
Allow autoprefixer to handle CSS prefixing
d240745
Modularize interaction handlers for easier refactoring
00af861
@shshaw
JSHint & code consistency fixes
0b17d16
@shshaw
Additional consistency fixes
5dc4eb4
@shshaw
Reuse $(this) reference
be7ccca
@shshaw
buildNav simplification
a4a5216 
Cleaned up and simplified the buildNav function
@shshaw
Loop setting, quote consistency, and misc small fixes
889b33e
@shshaw
Resize, Center & Init rebuilt. Now uses CSS Transforms (where possibl…
4ff1fe1 
…e) instead of positioning. New 'index' method for to update Flipster after adding/removing items
@shshaw
Autoplay fixes, better transform support detection and misc cleanup
a5e1148
@shshaw
Better keyboard, mouse wheel and touch events handling.
d3a111b
@shshaw
Autoplay fix
2a2dbae
@shshaw
Improved drag for touch only. Doesn't prevent vertical scrolling.
014a8ff
@shshaw
Standardized classes into one object for easy reference and updating.
5f9e7f5
@shshaw
Improved mouse wheel actions
1856c24
@shshaw
Formatting
fdbcfc3
@shshaw
Fallback if image load event doesn't get triggered
03f7ae4
@shshaw
Calculate offset AFTER item classes have been updated
d06a3f3
@shshaw
Restore biggest item height check to add support for `position: absol…
e29e330 
…ute` if needed.
@shshaw
Miscellaneous format consistencies
d1e18e7
@shshaw
Nav categories fix
589bb2d
@shshaw
Switched to LESS, adjusted Gruntfile, added uncompressed CSS output t…
6939114 
…o allow users to adjust styles as they need.
@shshaw
Watch JS & Less to compile
f0095e0
@shshaw
Default settings cleanup
b719387
@shshaw
Copy link
Collaborator Author
shshaw commented Jun 17, 2015

I think functionality-wise V1.0 is ready, but I haven't been able to fully browser test yet.

My plan was to make a gh-pages branch that's just what's under the /demo/ folder that would allow us to easily test and push changes. As I get time, I'll try to do that, but if you want to get V1 out, then feel free to start browser testing. You can let me know about any issues that pop up and I can try to debug.

@shshaw
Copy link
Collaborator Author
shshaw commented Oct 23, 2015

@drien I'm using the latest 1.0 version of Flipster on a project I'm about to launch and it's working as expected across all browsers, IE9+.

Any reason to hold off launching? If not, let's push it live.

@drien
Copy link
Owner
drien commented Oct 23, 2015

Sorry for not reviewing this for so long, very busy as always. Great work, I say go for it! 👍

On Oct 23, 2015, at 9:59 AM, Shaw notifications@github.com wrote:

@drien I'm using the latest 1.0 version of Flipster on a project I'm about to launch and it's working as expected across all browsers, IE9+.

Any reason to hold off launching? If not, let's push it live.

—
Reply to this email directly or view it on GitHub.

@shshaw
Copy link
Collaborator Author
shshaw commented Oct 23, 2015

No worries! Couldn't remember if there was anything we were holding off on other than browser testing which went quite well on my project. Doing some last minute checks then I'll push live. Thanks!

shshaw added a commit that referenced this pull request Oct 23, 2015
@shshaw
Merge pull request #54 from drien/v1
744c98c 
V1
@shshaw shshaw merged commit 744c98c into master Oct 23, 2015
@shshaw shshaw deleted the v1 branch October 23, 2015 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shshaw @drien
0