[#338] Added traits to create, configure blocks and block_content entities. #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds: - Feature test files for BlockTrait and BlockContentTrait - Updates to README.md to document available steps - Improved docblocks in both trait files for better description of parameters and examples - Added missing namespace to BlockContentTrait - Fixed parameter types and descriptions in method documentation - Created CLAUDE.md with guidelines for writing feature files - Added the traits to FeatureContext.php for testing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Refined BlockContentTrait with consistent naming and better errors - Renamed feature file for consistency - Updated message selectors for Drupal 10 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
richardgaunt
commented
Mar 23, 2025
| error_message_selector: '.messages.error' | ||
| success_message_selector: '.messages.status' | ||
| warning_message_selector: '.messages.warning' | ||
| error_message_selector: '.messages.messages--error' |
There was a problem hiding this comment.
Updated message_selector for each type:
richardgaunt
commented
Mar 23, 2025
CLAUDE.md
Outdated
| @@ -0,0 +1,112 @@ | |||
| # DrevOps Behat Steps | |||
There was a problem hiding this comment.
To remove - Claude instructions for reading and understanding project
|
Tests are passing but I think codecov seems to be making a bad request or maybe an access issue |
AlexSkrypnyk
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
@richardgaunt
Thank you so much for this excellent contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #338
Checklist before requesting a review
as
[#134] Added tests for block and block_content traits.Changedsection about WHY something wasdone if this was not a normal implementation
they passed
Changed
Summary of new steps
BlockTrait Steps
- When I create a block of type :label with: - Create a new block instance of an existing block
- When I configure the block with the label :label with: - Configure an existing block instance's settings (title, region, visibility)
- When I configure a visibility condition :condition for the block with label :label - Add visibility restrictions to a block instance
- When I remove the visibility condition :condition from the block with label :label - Remove visibility restrictions from a block instance
- When I disable the block with label :label - Make a block instance inactive
- When I enable the block with label :label - Make a block instance active
- Then block with label :label should exist - assert a block exists
- Then block with label :label should exist in the region :region - Assert a block is placed in a specific region
- Then block with label :label should not exist in the region :region - Assert a block is not in a specific region
- Then the block with label :label should have the visibility condition :condition - Assert visibility settings
- Then the block with label :label should not have the visibility condition :condition - Assert absence of visibility restrictions
- Then the block with label :label is disabled - Assert a block is inactive
- Then the block with label :label is enabled - Assert a block is active
BlockContentTrait Steps
Potential changes