8000 Email Trait idempotency fixes. by NigelCunninghamRGA · Pull Request #265 · drevops/behat-steps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Email Trait idempotency fixes. #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

NigelCunninghamRGA
Copy link
Contributor

The email trait doesn't check for the email tag before initialising in emailBeforeScenarioEnableTestEmailSystem. Depending on how scenarios are written and ordered, this will most likely result in the Drupal installation still having the test_mail_collector configured post run.

In addition, emailDisableTestEmailSystem invokes emailDeleteMailSystemOriginal inside the foreach instead of afterwards, preventing the correct restoration of config for second and subsequent email types.

The email trait doesn't check for the email tag before initialising in
emailBeforeScenarioEnableTestEmailSystem. Depending on how scenarios are
written and ordered, this will most likely result in the Drupal
installation still having the test_mail_collector configured post run.

In addition, emailDisableTestEmailSystem invokes
emailDeleteMailSystemOriginal inside the foreach instead of afterwards,
preventing the correct restoration of config for second and subsequent
email types.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>
@AlexSkrypnyk
Copy link
Member

This is excellent find! Thank you @NigelCunningham
It has helped to identify the inconsistency in how this trait was used in comparison to other traits which was fixed in #268

@AlexSkrypnyk AlexSkrypnyk merged commit ebfed47 into drevops:main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0