Email Trait idempotency fixes. #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The email trait doesn't check for the email tag before initialising in emailBeforeScenarioEnableTestEmailSystem. Depending on how scenarios are written and ordered, this will most likely result in the Drupal installation still having the test_mail_collector configured post run. In addition, emailDisableTestEmailSystem invokes emailDeleteMailSystemOriginal inside the foreach instead of afterwards, preventing the correct restoration of config for second and subsequent email types. Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>
|
This is excellent find! Thank you @NigelCunningham |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The email trait doesn't check for the email tag before initialising in emailBeforeScenarioEnableTestEmailSystem. Depending on how scenarios are written and ordered, this will most likely result in the Drupal installation still having the test_mail_collector configured post run.
In addition, emailDisableTestEmailSystem invokes emailDeleteMailSystemOriginal inside the foreach instead of afterwards, preventing the correct restoration of config for second and subsequent email types.