8000 Updated ElementTrait: Adding new an assert element with wildcard pattern exists. by tannguyen04 · Pull Request #260 · drevops/behat-steps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updated ElementTrait: Adding new an assert element with wildcard pattern exists. #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 1, 2024
Merged

Updated ElementTrait: Adding new an assert element with wildcard pattern exists. #260

merged 4 commits into from
Aug 1, 2024

Conversation

tannguyen04
Copy link
Contributor
@tannguyen04 tannguyen04 commented Jul 31, 2024 •
edited
Loading

Checklist before requesting a review

closes #245

  • I have formatted the subject to include ticket number
    as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

Changed

  1. Update README
  2. Support wildcard pattern for assert value of attribute & update tests.

Screenshots

@tannguyen04 tannguyen04 marked this pull request as ready for review July 31, 2024 08:11
@tannguyen04 tannguyen04 requested a review from AlexSkrypnyk July 31, 2024 08:11
AlexSkrypnyk
AlexSkrypnyk requested changes Jul 31, 2024
View reviewed changes
Copy link
Member
@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04
The linked issue in description is incorrect - should be #254

That issue is about adding a new assertion rather than replacing the old one. We still want to preserve the old one. Please update this PR.

@AlexSkrypnyk AlexSkrypnyk added the PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request label Jul 31, 2024
@tannguyen04 tannguyen04 changed the title Updated ElementTrait: Assert element with wildcard pattern exists. Updated ElementTrait: Adding new an assert element with wildcard pattern exists. Aug 1, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit c647483 into main Aug 1, 2024
1 check passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/element-trait-assert-attribute-value-wildcard-pattern branch August 1, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSkrypnyk AlexSkrypnyk AlexSkrypnyk approved these changes

Assignees

@tannguyen04 tannguyen04

Labels
PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase code coverage
2 participants
@tannguyen04 @AlexSkrypnyk
0