8000 Fixed deleting non existing menu items throwing errors. by tannguyen04 · Pull Request #259 · drevops/behat-steps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed deleting non existing menu items throwing errors. #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fixed deleting non existing menu items throwing errors. #259

merged 1 commit into from
Jul 31, 2024

Conversation

tannguyen04
Copy link
Contributor
@tannguyen04 tannguyen04 commented Jul 31, 2024 •
edited
Loading

Checklist before requesting a review

closes #253

  • I have formatted the subject to include ticket number
    as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04 tannguyen04 marked this pull request as ready for review July 31, 2024 07:31
@AlexSkrypnyk AlexSkrypnyk changed the title No throw error when deleting non existing menu items. Fixed deleting non existing menu items throwing errors. Jul 31, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 2237872 into main Jul 31, 2024
2 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/no-throw-error-deleting-non-existing-menu-items branch July 31, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSkrypnyk AlexSkrypnyk AlexSkrypnyk approved these changes

Assignees

@tannguyen04 tannguyen04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MenuTrait: Fix incorrectly throwing error on non-existing menu items.
2 participants
@tannguyen04 @AlexSkrypnyk
0