8000 [#161] Updated behat/mink-selenium2-driver to 1.7 by tannguyen04 · Pull Request #187 · drevops/behat-steps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#161] Updated behat/mink-selenium2-driver to 1.7 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2024
Merged

[#161] Updated behat/mink-selenium2-driver to 1.7 #187

merged 2 commits into from
Feb 26, 2024

Conversation

tannguyen04
Copy link
Contributor
@tannguyen04 tannguyen04 commented Feb 21, 2024 •
edited
Loading

Checklist before requesting a review

closes #161

  • I have formatted the subject to include ticket number
    as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04
Copy link
Contributor Author

Hi @AlexSkrypnyk
I have reviewed the change minkphp/MinkSelenium2Driver@v1.6.0...v1.7.0
And looks like only effect to our keyboard.feature which using keyboardTriggerKey function.

AlexSkrypnyk
AlexSkrypnyk requested changes Feb 22, 2024
View reviewed changes
Copy link
Member
@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04
Please see my comment.

Also, please see changes here minkphp/MinkSelenium2Driver@affb7ea and make sure that correct handling of keys is added to behat-steps.

Also, please add some tests to demostrate this.

composer.json Outdated
@@ -19,8 +19,8 @@
"require": {
"php": ">=8.1",
"behat/behat": "^3",
"behat/mink": "<=1.10",
"behat/mink-selenium2-driver": "<=1.6",
"behat/mink": "<=1.11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this constraint should be now saying >=1.11 and >=1.7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexSkrypnyk
I have update constraint as your requested.

I have re-reviewed the changes and handling of keys in our behat-step then could not find anything wrong.
Our behat-step using withSyn and executeJsOnXpath method on mink selenium, only withSyn method change as Syn to syn.

But I found other thing is the our keyboard trait look like does not handle correct even in main branch.
Please refer #189

@AlexSkrypnyk AlexSkrypnyk merged commit 2bdb122 into main Feb 26, 2024
@AlexSkrypnyk AlexSkrypnyk deleted the feature/update-mink-selenium-1-7 branch February 26, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSkrypnyk AlexSkrypnyk Awaiting requested review from AlexSkrypnyk

Assignees

@tannguyen04 tannguyen04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mink-selenium driver release 1.7 introduced BC issues
2 participants
@tannguyen04 @AlexSkrypnyk
0