8000 [#127] Made dynamic condition for no managed files step. by tannguyen04 · Pull Request #180 · drevops/behat-steps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#127] Made dynamic condition for no managed files step. #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2024
Merged

[#127] Made dynamic condition for no managed files step. #180

merged 2 commits into from
Feb 5, 2024

Conversation

tannguyen04
Copy link
Contributor

closes #127

AlexSkrypnyk
AlexSkrypnyk requested changes Feb 2, 2024
View reviewed changes
Copy link
Member
@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04
Please see my inline comments.

@tannguyen04
- Add more tests.
4c5b873 
- Change variable style to snake_case.
@tannguyen04
Copy link
Contributor Author

Hi @AlexSkrypnyk
I have updated as your request.

@tannguyen04 tannguyen04 marked this pull request as ready for review February 5, 2024 01:04
@AlexSkrypnyk AlexSkrypnyk merged commit 935f3b6 into drevops:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSkrypnyk AlexSkrypnyk AlexSkrypnyk approved these changes

Assignees

@tannguyen04 tannguyen04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent format of "Given no managed files:" step
2 participants
@tannguyen04 @AlexSkrypnyk
0