feat: add --log-to-stdout for command #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <gaius.qi@gmail.com>
BruceAko
approved these changes
May 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
=======================================
Coverage 49.33% 49.33%
=======================================
Files 58 58
Lines 12114 12114
=======================================
Hits 5977 5977
Misses 6137 6137
🚀 New features to boost your workflow:
|
yxxhero
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a change in the logging mechanism across multiple components of the project. The key update replaces the
--verboseflag with a new--log-to-stdoutflag for enabling detailed logs. This change affects Dockerfiles, service files, documentation, and the logging initialization function.Logging Flag Update:
ci/Dockerfile,ci/Dockerfile.debug, andci/Dockerfile.dfinit: Updated thecargo buildcommand to use the--log-to-stdoutflag instead of--verbosefor logging. [1] [2] [3]ci/dfdaemon.service: Replaced the--verboseflag with--log-to-stdoutin theExecStartcommand for thedfdaemonservice.Documentation Updates:
docs/performance-optimization.md: Updated example commands to use--log-to-stdoutinstead of--verbose.dragonfly-client-backend/examples/plugin/README.md: Adjusted example commands to reflect the new--log-to-stdoutflag.Codebase Adjustment:
dragonfly-client/src/tracing/mod.rs: Refactored theinit_tracingfunction to replace theverboseparameter withlog_to_stdout, ensuring consistent behavior with the new flag. [1] [2]Related Issue
Motivation and Context
Screenshots (if appropriate)