Add loading indicator #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a barrel file to the shared folder in order to make it simpler to consume things from it.
bruno-garcia
approved these changes
Oct 5, 2019
|
Awesome stuff @joaopgrassi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the loading from https://codepen.io/ispal/pen/mVaaJe/
Codepen license is MIT for public pens, so I think we should be okay from the "legal" side.
Here's a preview of how it looks on the site:
It would be nice as @bruno-garcia mentioned to have the icon change its size based on the viewport, but that's too advanced for my CSS skills 😅. The whole animation is done by CSS and it's quite tricky to make it dynamic. So.. I guess for now that will have to do it. We can open another issue and ask for help.
Closes #69