8000 [builds] Make sure downloaded files have a newer timestamp than any other file from previous builds. by rolfbjarne · Pull Request #7833 · dotnet/macios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[builds] Make sure downloaded files have a newer timestamp than any other file from previous builds. #7833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

[builds] Make sure downloaded files have a newer timestamp than any other file from previous builds. #7833

merged 1 commit into from
Feb 10, 2020

Conversation

rolfbjarne
Copy link
Member

This makes sure we actually use the new files we downloaded.

@rolfbjarne
[builds] Make sure downloaded files have a newer timestamp than any o…
1a07daf 
…ther file from previous builds.

This makes sure we actually use the new files we downloaded.
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Feb 10, 2020
@chamons
Copy link
Contributor
chamons commented Feb 10, 2020

How in the world is this not the case?

@rolfbjarne
Copy link
Member Author

How in the world is this not the case?

7z restores the timestamp from archives as well.

mono/mono#18779 (comment)

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@rolfbjarne rolfbjarne merged commit 999ba8e into dotnet:master Feb 10, 2020
@rdebath rdebath mentioned this pull request Apr 25, 2021
Open
@rdebath rdebath mentioned this pull request Jul 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@chamons chamons chamons approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rolfbjarne @chamons @monojenkins @dalexsoto @spouliot @mandel-macaque
0