8000 [release/9.2] Fixed resolving secrets for keyvault references in run mode by github-actions[bot] · Pull Request #8755 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[release/9.2] Fixed resolving secrets for keyvault references in run mode #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

[release/9.2] Fixed resolving secrets for keyvault references in run mode #8755

merged 2 commits into from
Apr 18, 2025

Conversation

github-actions[bot]
Copy link
Contributor
@github-actions github-actions bot commented Apr 13, 2025 •
edited by davidfowl
Loading

Backport of #8751 to release/9.2

/cc @davidfowl

Customer Impact

The new first class key vault secret reference feature does not work in run mode after the first run. This makes it impossible to move away from bicep secret outputs in your own resources or use any of our resources with key references in run mode.

Testing

Manul on the customer's repro.

Risk

Low

Regression?

Yes.

@davidfowl
Fixed resolving secrets for keyvault refernces in run mode - Moved to…
43bbb5a 
…ken credential resolution out of the AzureProvisioner so it can shared. - Configure the secret resolving in both configure and provision cases.
@davidfowl davidfowl added this to the 9.2 milestone Apr 13, 2025
@joperezr joperezr modified the milestones: 9.2, 9.2.1 (Servicing) Apr 15, 2025
@davidfowl davidfowl mentioned this pull request Apr 15, 2025
Closed
1 task
@danmoseley danmoseley added area-integrations Issues pertaining to Aspire Integrations packages Servicing-approved Approved for servicing release labels Apr 16, 2025
@davidfowl davidfowl merged commit 7187153 into release/9.2 Apr 18, 2025
174 checks passed
@davidfowl davidfowl deleted the backport/pr-8751-to-release/9.2 branch April 18, 2025 18:40
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl left review comments

@eerhardt eerhardt eerhardt approved these changes

@mitchdenny mitchdenny mitchdenny approved these changes

Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages Re-opened Github-Action PR Servicing-approved Approved for servicing release
Projects
None yet
Milestone
9.2.1 (Servicing)
Development

Successfully merging this pull request may close these issues.
5 participants
@davidfowl @mitchdenny @eerhardt @danmoseley @joperezr
0